Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove 'c' from knip.jsonc extension #1247

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

I don't know why the trailing comma is happening... but there's no need for the file to be .jsonc anyway. It only used to have comments.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6774141) 94.81% compared to head (5c21520) 94.81%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1247   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files         104      104           
  Lines        5804     5804           
  Branches      492      492           
=======================================
  Hits         5503     5503           
  Misses        300      300           
  Partials        1        1           
Flag Coverage Δ
create 70.07% <20.00%> (ø)
initialize 42.26% <80.00%> (ø)
migrate 69.88% <20.00%> (ø)
unit 75.59% <80.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 0d54604 into main Jan 16, 2024
16 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the knip-json-no-c branch January 16, 2024 20:51
Copy link

🎉 This is included in version v1.54.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: End-to-end failures on main for create
1 participant