Skip to content

fix: remove hydrate entries from package.json in setup #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Adds a couple of removals and clumps them together.

@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Merging #571 (533b974) into main (d5c409d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   88.21%   88.21%           
=======================================
  Files          56       56           
  Lines        3071     3073    +2     
  Branches      123      123           
=======================================
+ Hits         2709     2711    +2     
  Misses        358      358           
  Partials        4        4           
Flag Coverage Δ
hydrate 78.03% <0.00%> (-0.06%) ⬇️
setup 69.98% <100.00%> (+0.05%) ⬆️
unit 42.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/setup/steps/updateLocalFiles.ts 90.24% <100.00%> (+0.24%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg merged commit ddf66f0 into main Jun 18, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the setup-remove-hydrate-from-package-json branch June 18, 2023 12:26
@github-actions
Copy link

🎉 This is included in version v1.28.36 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Setup script should remove hydrate entries from package.json
1 participant