Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move --report-unused-disable-directives cli option to .eslintrc.cjs #731

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

ryota-murakami
Copy link
Contributor

PR Checklist

Overview

I don't know this is intended, but generally forks include me preferred set in config file rather than cli options.

thanks take a look the PR!

@JoshuaKGoldberg JoshuaKGoldberg changed the title eslint: move --eport-unused-disable-directives cli option to .eslintrc.cjs eslint: move --report-unused-disable-directives cli option to .eslintrc.cjs Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #731 (ba39f0c) into main (990bc52) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #731   +/-   ##
=======================================
  Coverage   91.10%   91.10%           
=======================================
  Files          82       82           
  Lines        3990     3990           
  Branches      223      223           
=======================================
  Hits         3635     3635           
  Misses        354      354           
  Partials        1        1           
Flag Coverage Δ
create 72.78% <ø> (ø)
initialize 33.50% <ø> (ø)
migrate 72.88% <ø> (ø)
unit 36.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 awesome! I'd missed that this was added to the config file options. Thanks for sending it in!

Just a few CI failures on the PR:

I'll just apply these now since they're not really related to the functional changes you made. Just a heads up 🙂

@JoshuaKGoldberg JoshuaKGoldberg changed the title eslint: move --report-unused-disable-directives cli option to .eslintrc.cjs feat: move --report-unused-disable-directives cli option to .eslintrc.cjs Aug 31, 2023
@JoshuaKGoldberg
Copy link
Owner

OH and createESLintRC.ts needs to include these changes. I'll send that up too.

@JoshuaKGoldberg JoshuaKGoldberg merged commit f906763 into JoshuaKGoldberg:main Aug 31, 2023
13 of 14 checks passed
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @ryota-murakami for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @ryota-murakami! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@github-actions
Copy link

🎉 This is included in version v1.29.15 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg pushed a commit that referenced this pull request Aug 31, 2023
Adds @ryota-murakami as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#731 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@ryota-murakami
Copy link
Contributor Author

@JoshuaKGoldberg Thank you for confirm the PR!
I'm using this template with own customize(swap to https://github.com/laststance/eslint-config-ts-prefixer etc) although there are a lot of points which should I learn.

Especially create new app and migrate existing projects CLI script are great resource for me!

👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants