-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move --report-unused-disable-directives
cli option to .eslintrc.cjs
#731
feat: move --report-unused-disable-directives
cli option to .eslintrc.cjs
#731
Conversation
--eport-unused-disable-directives
cli option to .eslintrc.cjs
--report-unused-disable-directives
cli option to .eslintrc.cjs
Codecov Report
@@ Coverage Diff @@
## main #731 +/- ##
=======================================
Coverage 91.10% 91.10%
=======================================
Files 82 82
Lines 3990 3990
Branches 223 223
=======================================
Hits 3635 3635
Misses 354 354
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 awesome! I'd missed that this was added to the config file options. Thanks for sending it in!
Just a few CI failures on the PR:
- Compliance: "This PR's title should conform to specification at https://conventionalcommits.org/".
- The bot should have posted this in the PR. Filed 🐛 Bug: Compliance bot isn't posting comments on PRs from forks #732 on myself to see why it's not
.eslintrc.cjs
should be in sorted order
I'll just apply these now since they're not really related to the functional changes you made. Just a heads up 🙂
--report-unused-disable-directives
cli option to .eslintrc.cjs
--report-unused-disable-directives
cli option to .eslintrc.cjs
OH and |
@all-contributors please add @ryota-murakami for code.
|
I've put up a pull request to add @ryota-murakami! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
🎉 This is included in version v1.29.15 🎉 The release is available on: Cheers! 📦🚀 |
Adds @ryota-murakami as a contributor for code. This was requested by JoshuaKGoldberg [in this comment](#731 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@JoshuaKGoldberg Thank you for confirm the PR! Especially create new app and migrate existing projects CLI script are great resource for me! 👋 |
PR Checklist
Overview
I don't know this is intended, but generally forks include me preferred set in config file rather than cli options.
thanks take a look the PR!