Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: renamed *:test to test:* in every file #811

Merged
merged 6 commits into from
Sep 7, 2023
Merged

build: renamed *:test to test:* in every file #811

merged 6 commits into from
Sep 7, 2023

Conversation

DanexQ
Copy link
Contributor

@DanexQ DanexQ commented Sep 6, 2023

PR Checklist

Overview

Also fixed a typo "initiamigratelize" in .github/workflows/DEVELOPMENT.md.

JoshuaKGoldberg
JoshuaKGoldberg reviewed Sep 7, 2023
View reviewed changes
.github/DEVELOPMENT.md
@@ -183,7 +183,7 @@ node ../create-typescript-app/bin/migrate.js
You can run the end-to-end test for migrating locally on the command-line:

```shell
pnpm run initiamigratelize:test
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, whoops... thanks for the fix.

JoshuaKGoldberg
JoshuaKGoldberg requested changes Sep 7, 2023
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, thanks! I think it's just missing a few workflow file updates (one for each command).

package.json Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Sep 7, 2023
@DanexQ
Copy link
Contributor Author

DanexQ commented Sep 7, 2023

Sorry, I was sure that I changed it there. Now everything should be fine.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 7, 2023
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell, thanks! ✨

package.json Outdated
"lint": "eslint . .*js --max-warnings 0",
"lint:knip": "knip",
"lint:md": "markdownlint \"**/*.md\" \".github/**/*.md\" --rules sentences-per-line",
"lint:package-json": "npmPkgJsonLint .",
"lint:packages": "pnpm dedupe --check",
"lint:spelling": "cspell \"**\" \".github/**/*\"",
"migrate:test": "node script/migrate-test-e2e.js",
"test:migrate": "node script/migrate-test-e2e.js",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, forgot to mention, I like keeping these scripts sorted alphabetically 😄. Grouping them by name is helpful for scanning through & seeing all the options. And it helps searchability.

When I try this locally, the formatter does it... I'm surprised this isn't failing any CI tasks?

🤷 I can do it since I forgot to ask before

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #811 (f23a316) into main (6bcf979) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #811   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files          84       84           
  Lines        4160     4160           
  Branches      248      248           
=======================================
  Hits         3811     3811           
  Misses        349      349
Flag Coverage Δ
create 72.03% <0.00%> (ø)
initialize 34.06% <100.00%> (ø)
migrate 73.34% <100.00%> (ø)
unit 47.69% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/steps/updateLocalFiles.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix: renamed *:test to test:* in every file build: renamed *:test to test:* in every file Sep 7, 2023
@JoshuaKGoldberg
Copy link
Owner

And, changed to build: because this doesn't impact end-users.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 486f89d into JoshuaKGoldberg:main Sep 7, 2023
16 of 17 checks passed
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @DanexQ for infra.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this pull request Sep 7, 2023
Closed
@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @DanexQ! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

🎉 This is included in version v1.29.37 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
status: waiting for author Needs an action taken by the original poster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Rename *:test to test:*
2 participants
@DanexQ @JoshuaKGoldberg