-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace format:write to format --write #815
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good start, but let's remove the old unnecessary script rather than just rename it.
TIL scripts can have spaces in their names! pnpm run "format --write"
😄
package.json
Outdated
@@ -25,7 +25,7 @@ | |||
"build": "tsup", | |||
"create:test": "node script/create-test-e2e.js", | |||
"format": "prettier \"**/*\" --ignore-unknown", | |||
"format:write": "pnpm format --write", | |||
"format --write": "pnpm format --write", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea here was to remove this extra script altogether:
"format --write": "pnpm format --write", |
Codecov Report
@@ Coverage Diff @@
## main #815 +/- ##
==========================================
+ Coverage 91.61% 92.18% +0.56%
==========================================
Files 84 84
Lines 4161 4220 +59
Branches 248 261 +13
==========================================
+ Hits 3812 3890 +78
+ Misses 349 330 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
You're right. Hope it's fine. |
@@ -103,7 +103,7 @@ describe("writePackageJson", () => { | |||
"scripts": { | |||
"build": "tsup", | |||
"format": "prettier \\"**/*\\" --ignore-unknown", | |||
"format:write": "pnpm format --write", | |||
"format --write": "pnpm format --write", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanexQ this is still buggy - it should be removed.
@DanexQ I'm going to go ahead and close this out, as I want this feature in before Hacktoberfest this coming week. Thanks for trying it out though! ❤️ |
PR Checklist
status: accepting prs
Overview
All
format:write
has been replaced withformat --write
.