Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only append README.md notice if it doesn't yet exist #845

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Uses the <!-- ... --> line as a detector to know whether to append.

Note that creation was fixed previously, just not appending (updating).

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #845 (cd6abf0) into main (dd2392a) will increase coverage by 0.02%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
+ Coverage   92.16%   92.19%   +0.02%     
==========================================
  Files          84       84              
  Lines        4226     4240      +14     
  Branches      263      264       +1     
==========================================
+ Hits         3895     3909      +14     
  Misses        331      331              
Flag Coverage Δ
create 71.82% <50.00%> (-0.15%) ⬇️
initialize 34.82% <100.00%> (+0.21%) ⬆️
migrate 71.21% <50.00%> (+<0.01%) ⬆️
unit 52.71% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/steps/updateReadme.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg merged commit 67612d7 into main Sep 19, 2023
16 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the append-readme-as-needed branch September 19, 2023 20:24
@github-actions
Copy link

🎉 This is included in version v1.29.46 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Migration script re-adds end of README.md notice
1 participant