Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧪 Testing: Add tests for type snapshots #114

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 19, 2023 · 1 comment · Fixed by #639
Closed
3 tasks done

🧪 Testing: Add tests for type snapshots #114

JoshuaKGoldberg opened this issue Dec 19, 2023 · 1 comment · Fixed by #639
Labels
area: testing Improving how the repository's tests are run and/or code is tested 🧪 status: accepting prs Please, send a pull request to resolve this! 🙏

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Spinning out of #113: that PR included no test changes because the impacted lines weren't previously covered by tests at all. Accepting PRs to add tests in!

Additional Info

Note that type snapshots impact the file system, so it might be nontrivial to set up testing for them. My hunch is to try using Vitest mocking.
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! 🙏 area: testing Improving how the repository's tests are run and/or code is tested 🧪 labels Dec 19, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Nov 29, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Nov 29, 2024
@JoshuaKGoldberg
fix: remove unusable message IDs (#639)
8452533 
## PR Checklist

- [x] Addresses an existing open issue: fixes #114; fixes #636; fixes
#638
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-expect-type/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-expect-type/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Removes the unreachable `FileIsNotIncludedInTSConfig` and
`Multiple$ExpectTypeAssertions` message IDs.

Also fills in some tests around snapshots (#114) to feel more safe in
doing so.

💖
@github-actions GitHub Actions
Copy link

🎉 This is included in version v0.5.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: testing Improving how the repository's tests are run and/or code is tested 🧪 status: accepting prs Please, send a pull request to resolve this! 🙏
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove unusable message IDs JoshuaKGoldberg/eslint-plugin-expect-type
1 participant
@JoshuaKGoldberg