Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃И Testing: Add tests for type snapshots #114

Open
3 tasks done
JoshuaKGoldberg opened this issue Dec 19, 2023 · 0 comments
Open
3 tasks done

馃И Testing: Add tests for type snapshots #114

JoshuaKGoldberg opened this issue Dec 19, 2023 · 0 comments
Labels
area: testing Improving how the repository's tests are run and/or code is tested status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Spinning out of #113: that PR included no test changes because the impacted lines weren't previously covered by tests at all. Accepting PRs to add tests in!

Additional Info

Note that type snapshots impact the file system, so it might be nontrivial to set up testing for them. My hunch is to try using Vitest mocking.
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! area: testing Improving how the repository's tests are run and/or code is tested labels Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: testing Improving how the repository's tests are run and/or code is tested status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg