Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: explain assignability vs. display checking #50

Closed
JoshuaKGoldberg opened this issue Apr 14, 2022 · 1 comment · Fixed by #118
Closed

Documentation: explain assignability vs. display checking #50

JoshuaKGoldberg opened this issue Apr 14, 2022 · 1 comment · Fixed by #118
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏

Comments

@JoshuaKGoldberg
Copy link
Owner

Overview

See this Twitter thread: https://twitter.com/JoshuaKGoldberg/status/1514631630006149120 / https://twitter.com/danvdk/status/1514631780241850370.

This should be noted in the docs, with links to packages like expect-type.
@JoshuaKGoldberg JoshuaKGoldberg added type: docs status: accepting prs Please, send a pull request to resolve this! 🙏 labels Apr 14, 2022
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 5, 2022
Merged
2 tasks
@JoshuaKGoldberg
Copy link
Owner Author

Also, #67 (comment)

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 19, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Dec 19, 2023
@JoshuaKGoldberg
docs: add explanation of display checking (#118)
b6c757d 
<!-- 👋 Hi, thanks for sending a PR to eslint-plugin-expect-type! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #50
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-expect-type/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-expect-type/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds a brief note in the `expect` rule docs.

I don't think we need more than that given the README.md links to
neighboring packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add explanation of display checking JoshuaKGoldberg/eslint-plugin-expect-type
1 participant
@JoshuaKGoldberg