Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split functionality internally #117

Merged
merged 3 commits into from
Dec 21, 2023
Merged

chore: split functionality internally #117

merged 3 commits into from
Dec 21, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 19, 2023

PR Checklist

Overview

Splits out the roughly-not-specific-to-ESLint logic from the expect rule into:

  • src/assertions: parsing assertions out from source code
  • src/failures: determined unmatched/unmet assertions
  • src/utils: miscellaneous helpers

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 188 lines in your changes are missing coverage. Please review.

Comparison is base (5dfdd92) 81.79% compared to head (291f2d5) 73.15%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/assertions/types.ts 0.00% 76 Missing ⚠️
src/utils/typescript.ts 46.72% 57 Missing ⚠️
src/failures/types.ts 0.00% 21 Missing ⚠️
src/rules/expect.ts 80.00% 18 Missing ⚠️
src/assertions/parseAssertions.ts 90.44% 13 Missing ⚠️
src/failures/getExpectTypeFailures.ts 97.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   81.79%   73.15%   -8.65%     
==========================================
  Files          10       16       +6     
  Lines         835      946     +111     
  Branches       93       85       -8     
==========================================
+ Hits          683      692       +9     
- Misses        152      254     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review December 20, 2023 17:03
@JoshuaKGoldberg
Copy link
Owner Author

@danvk adding you since we're talking soon - if you have time, thought you might enjoy discussing the refactor 😄

@JoshuaKGoldberg
Copy link
Owner Author

Ah, this is blocking me working on more parts of the plugin. I'm going to merge now - but let me know if there's anything you think I could have done better here!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 740cd78 into main Dec 21, 2023
14 of 16 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the refactor-split branch December 21, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Refactor large expect rule into granular pieces
1 participant