Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migrate to create-typescript-app@1 #88

Merged
merged 18 commits into from
Nov 13, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 5, 2023

PR Checklist

Overview

Note to self: I might apply just the Prettier changes to main in a separate PR first, just to reduce diff count here... and then I can add a .git-blame-ignore-revs file (https://github.blog/changelog/2022-03-24-ignore-commits-in-the-blame-view-beta) to ignore them. There's still a big diff even with them ignored. 😞

@JoshuaKGoldberg
Copy link
Owner Author

Blast from the past-ish! bmish/eslint-doc-generator#446

@JoshuaKGoldberg
Copy link
Owner Author

The actual error locally is:

require() of ES Module /Users/josh/repos/eslint-plugin-expect-type/lib/index.js from /Users/josh/repos/eslint-plugin-expect-type/node_modules/.pnpm/eslint-doc-generator@1.4.3_eslint@8.48.0_typescript@5.2.2/node_modules/eslint-doc-generator/dist/lib/package-json.js not supported.
Instead change the require of index.js in /Users/josh/repos/eslint-plugin-expect-type/node_modules/.pnpm/eslint-doc-generator@1.4.3_eslint@8.48.0_typescript@5.2.2/node_modules/eslint-doc-generator/dist/lib/package-json.js to a dynamic import() which is available in all CommonJS modules.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review September 5, 2023 23:49
Copy link

codecov bot commented Nov 13, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@JoshuaKGoldberg JoshuaKGoldberg merged commit bf98512 into main Nov 13, 2023
13 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the create-typescript-app-1 branch November 13, 2023 00:37
@danvk
Copy link
Collaborator

danvk commented Nov 13, 2023

Hooray! 🎉 🚀 👏

@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @JoshuaKGoldberg for infra.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

We had trouble processing your request. Please try again later.

@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @JoshuaKGoldberg for infra.

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @JoshuaKGoldberg! 🎉

JoshuaKGoldberg pushed a commit that referenced this pull request Dec 20, 2023
Adds @JoshuaKGoldberg as a contributor for infra.

This was requested by JoshuaKGoldberg [in this
comment](#88 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overhaul development flow
2 participants