fix(valid-package-def): ignore pnpm workspace protocol #258
Conversation
pnpm has a "workspace protocol" (link) that allows you to explicitly say a package lives in your current workspace. Ignore this when doing package.json validation. This fixes JoshuaKGoldberg#251
altano
force-pushed
the
altano/pnpm-workspace-protocol
branch
from
f210640 to
d4adc8f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
==========================================
- Coverage 99.30% 99.27% -0.04%
==========================================
Files 15 17 +2
Lines 866 965 +99
Branches 73 81 +8
==========================================
+ Hits 860 958 +98
- Misses 6 7 +1 ☔ View full report in Codecov by Sentry. |
|
@all-contributors please add @altano for code.
|
|
I've put up a pull request to add @altano! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
|
🎉 This is included in version v0.12.1 🎉 The release is available on: Cheers! 📦🚀 |
Adds @altano as a contributor for code. This was requested by JoshuaKGoldberg [in this comment](#258 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
PR Checklist
status: accepting prsOverview
pnpm has a "workspace protocol" (link) that allows you to explicitly say a package lives in your current workspace. Ignore this when doing package.json validation by adding
workspaceto the ignore glob.