Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: No longer works in latest GitHub web update #161

Closed
3 tasks done
JoshuaKGoldberg opened this issue Nov 2, 2023 · 1 comment · Fixed by #166
Closed
3 tasks done

🐛 Bug: No longer works in latest GitHub web update #161

JoshuaKGoldberg opened this issue Nov 2, 2023 · 1 comment · Fixed by #166
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Nov 2, 2023 •
edited
Loading

Status (Mid-November 2023): I've submitted a fix to the Chrome Web Store. We're waiting for approval now.

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

This should still work in the latest github.com UI refresh.

Actual

The new UI is different enough from the old one that this extension no longer does anything 😬

Screenshot of the new GitHub modal saved replies

Additional Info

...annoyed that GitHub downgraded the experience to a modal but you still can't have org or repo saved replies 😠
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Nov 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Nov 14, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Nov 14, 2023
@JoshuaKGoldberg
fix: got working again in new GitHub web UI (#166)
b24e0d9 
## PR Checklist

- [x] Addresses an existing open issue: fixes #161
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/refined-saved-replies/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/refined-saved-replies/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Gets it working in the new modal world with minimal changes.
@JoshuaKGoldberg
Copy link
Owner Author

Status update: I submitted this to the Chrome extension marketplace last month. Still waiting for it to be approved. 😞

You can always self-host this extension in the meantime by following the development steps.

@JoshuaKGoldberg JoshuaKGoldberg pinned this issue Jan 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg unpinned this issue Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: got working again in new GitHub web UI JoshuaKGoldberg/refined-saved-replies
1 participant
@JoshuaKGoldberg