Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub Validation and improvements #274

Merged
merged 29 commits into from
Nov 18, 2022
Merged

Stub Validation and improvements #274

merged 29 commits into from
Nov 18, 2022

Conversation

Josverl
Copy link
Owner

@Josverl Josverl commented Nov 14, 2022

createstubs

  • use text file to store progress instead of btree to work on more ports
  • re-add some modules to stub-list: io/uio

stubber

  • autoflake: remove fewer imports
  • docstubs
    • basic log message if not verbose
    • fix: parameters ending in ... to generate *args, **kwargs
    • stubpacker: fix tomlib / tomllib parity
    • always copy dependencies from template (use to add micropython-stdlib-stubs )
    • fix: os.uname() tuple/named tuple

snippets validation

  • add common snippets
  • use pyright config per port
  • update snippets after validation on hardware snippets on hardware

Note:
this causes an issue with converting coverage to .xml and .lcov formats.
this has been (temporarily) removed from the test action

@lgtm-com
Copy link

lgtm-com bot commented Nov 14, 2022

This pull request introduces 2 alerts when merging 504f693 into 2d4b65e - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Variable defined multiple times

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2022

This pull request introduces 2 alerts when merging 21e6787 into 2d4b65e - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Variable defined multiple times

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2022

This pull request introduces 2 alerts when merging 03e7914 into 2d4b65e - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Variable defined multiple times

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #274 (19aea36) into main (1b697b5) will decrease coverage by 3.87%.
The diff coverage is 70.73%.

❗ Current head 19aea36 differs from pull request most recent head cd715ac. Consider uploading reports for the commit cd715ac to get more accurate results

@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
- Coverage   87.74%   83.86%   -3.88%     
==========================================
  Files          54       55       +1     
  Lines        2741     2771      +30     
  Branches      493      491       -2     
==========================================
- Hits         2405     2324      -81     
- Misses        215      316     +101     
- Partials      121      131      +10     
Impacted Files Coverage Δ
src/stubber/rst/output_dict.py 87.07% <ø> (ø)
src/stubber/publish/merge_docstubs.py 60.41% <12.50%> (-6.25%) ⬇️
src/stubber/utils/post.py 61.76% <31.25%> (-28.24%) ⬇️
src/stubber/codemod/enrich.py 39.58% <40.00%> (-37.97%) ⬇️
src/stubber/commands/upd_module_list_cmd.py 75.00% <75.00%> (ø)
src/stubber/publish/stubpacker.py 77.77% <89.47%> (-8.24%) ⬇️
src/stubber/commands/get_docstubs_cmd.py 81.25% <100.00%> (+0.60%) ⬆️
src/stubber/commands/stub_cmd.py 100.00% <100.00%> (ø)
src/stubber/freeze/common.py 75.00% <100.00%> (ø)
src/stubber/minify.py 86.31% <100.00%> (-8.59%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2022

This pull request introduces 2 alerts when merging 19aea36 into 2d4b65e - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Variable defined multiple times

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2022

This pull request introduces 2 alerts when merging 095af2f into 2d4b65e - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Variable defined multiple times

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2022

This pull request introduces 2 alerts when merging eb753af into 2d4b65e - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Variable defined multiple times

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2022

This pull request introduces 2 alerts when merging cd715ac into 2d4b65e - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Variable defined multiple times

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@Josverl Josverl changed the title Validate stubs and associated updates Stub Validation and improvements Nov 18, 2022
@Josverl Josverl merged commit 1054268 into main Nov 18, 2022
@Josverl Josverl deleted the dev/use_modules_done branch November 18, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant