Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Jetty 11 #404

Open
DavidWhitlock opened this issue May 21, 2022 · 2 comments
Open

Upgrade to Jetty 11 #404

DavidWhitlock opened this issue May 21, 2022 · 2 comments

Comments

@DavidWhitlock
Copy link
Collaborator

While working on #402, I attempted to upgrade the jetty-maven-plugin to the latest release, 11.0.9. However, the web application wouldn't start because of:

Caused by: java.lang.IllegalStateException: class com.google.inject.servlet.GuiceFilter is not a jakarta.servlet.Filter

GuiceFilter indeed appears to not implement the jakarta Filter: https://github.com/google/guice/blob/master/extensions/servlet/src/com/google/inject/servlet/GuiceFilter.java

I'm not sure what to do here. Maybe I can write my own jakarta Filter that wraps a GuiceFilter?

In the meantime, I'll stay on Jetty 9.
DavidWhitlock added a commit that referenced this issue May 21, 2022
@DavidWhitlock
Update Jetty to latest 9.X release. I don't think we're ready for tha…
11ff833 
…t Jetty. 11, that is. It doesn't work with the GuiceFilter. See #404
@DavidWhitlock DavidWhitlock mentioned this issue Sep 10, 2022
Merged
@DavidWhitlock
Copy link
Collaborator Author

Some discussion at google/guice#1490

DavidWhitlock added a commit that referenced this issue Dec 22, 2022
@DavidWhitlock
Merge pull request #428 from DavidWhitlock/2023.0.0-SNAPSHOT
208ed3b 
Changes for Winter 2023

  * Resolve #424 by generating project time estimates for the koans project and generating summary for multiple terms of data
  * Upgraded Jetty to 10.0.11.  This is related to #404.
  * Make small improvements to the REST projects to resolve #423 
  * Resolve #410 by renaming `student.version` to `grader.version`.
  * Resolve #418 by changing the Survey program to reject a student id that is not a Java identifier.
  * Resolve #422 by adding comments that clarify that the TextDumper and TextParser classes are for Project 2.
  * Resolve #420 by making guava a top-level dependency available to all projects
  * Resolve #419 by adding a site.xml to the projects and their archetypes.
  * Updated Maven plugin and third-party dependencies to their latest versions
  * Resolve #425 by not including an assignment in the Grade Summary Report for which all of its grades are zero. Along the way, I got rid of some warnings and code smells.
@DavidWhitlock
Copy link
Collaborator Author

It looks like Guice 7.0 supports the Jakarta APIs: https://github.com/google/guice/wiki/Guice700

But it looks like the resteasy-guice module was removed: https://issues.redhat.com/browse/RESTEASY-3329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavidWhitlock