Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate and includable input schema files #188

Closed
bedeho opened this issue Jan 29, 2021 · 5 comments
Closed

Separate and includable input schema files #188

bedeho opened this issue Jan 29, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request highest-prio-feature Highest priority new feature

Comments

@bedeho
Copy link
Member

bedeho commented Jan 29, 2021

Its getting exceedingly hard to manage everything in one file, its quite clearly not going to scale, so being able to have separate files where one can include one into another as a dependency, similar to C/C++ header files in a preprocessing stage.

@bedeho bedeho added idea enhancement New feature or request labels Jan 29, 2021
@dzhelezov
Copy link
Contributor

That's doable and shouldn't be hard to implement

@bedeho
Copy link
Member Author

bedeho commented Jan 29, 2021

That would be great, would we be able to preserve line numbers in parsing errors that match the original files?

@dzhelezov
Copy link
Contributor

We don’t track line numbers when an error is thrown, just report the name of the entity

@bedeho
Copy link
Member Author

bedeho commented Jan 29, 2021

Ok, guess its a moot point then, looking forward to trying when available.

@bedeho bedeho added highest-prio-feature Highest priority new feature and removed idea labels Feb 6, 2021
@bedeho
Copy link
Member Author

bedeho commented Feb 6, 2021

I think the simplest way to do this, without having to deal with dependencies problems, is perhaps to just allow the manifest to take multiple input file entries, and not introduce some complex directive or other means of including schema files into each other. That buys us the basic ability to break things up we need.

Sulejman added a commit to Sulejman/hydra that referenced this issue Feb 15, 2021
dzhelezov pushed a commit that referenced this issue Feb 18, 2021
* Separate schema files

#188

* Update .gitignore

* Refactored SchemaParser to accept folders

* test for separate includable schema files

* fixing relative path in codegen

* Update SchemaParser.ts

Lint error, unused import fix

* Changelog and version bump

* Update package.json

Updating sample project hydra-cli version

* reverting relative path fix
@metmirr metmirr closed this as completed Feb 23, 2021
dzhelezov pushed a commit to dzhelezov/hydra that referenced this issue Mar 1, 2021
* Separate schema files

Joystream#188

* Update .gitignore

* Refactored SchemaParser to accept folders

* test for separate includable schema files

* fixing relative path in codegen

* Update SchemaParser.ts

Lint error, unused import fix

* Changelog and version bump

* Update package.json

Updating sample project hydra-cli version

* reverting relative path fix
dzhelezov pushed a commit to dzhelezov/hydra that referenced this issue Mar 1, 2021
* Separate schema files

Joystream#188

* Update .gitignore

* Refactored SchemaParser to accept folders

* test for separate includable schema files

* fixing relative path in codegen

* Update SchemaParser.ts

Lint error, unused import fix

* Changelog and version bump

* Update package.json

Updating sample project hydra-cli version

* reverting relative path fix
dzhelezov pushed a commit to dzhelezov/hydra that referenced this issue May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request highest-prio-feature Highest priority new feature
Projects
None yet
Development

No branches or pull requests

4 participants