Prelim work #3
Merged
Prelim work #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ablaom
reviewed
Feb 8, 2024
ablaom
reviewed
Feb 8, 2024
ablaom
reviewed
Feb 8, 2024
ablaom
reviewed
Feb 8, 2024
ablaom
reviewed
Feb 8, 2024
ablaom
reviewed
Feb 8, 2024
ablaom
reviewed
Feb 8, 2024
ablaom
reviewed
Feb 8, 2024
ablaom
reviewed
Feb 8, 2024
ablaom
reviewed
Feb 8, 2024
ablaom
reviewed
Feb 8, 2024
ablaom
reviewed
Feb 9, 2024
ablaom
reviewed
Feb 9, 2024
ablaom
reviewed
Feb 9, 2024
|
Could we please have a example, including the use of TunedModel, in the readme - or in Documeter.jl docs if you prefer? |
|
@OkonSamuel I didn't review the |
ablaom
reviewed
Feb 14, 2024
ablaom
reviewed
Feb 14, 2024
ablaom
reviewed
Feb 14, 2024
ablaom
reviewed
Feb 14, 2024
ablaom
reviewed
Feb 14, 2024
Co-authored-by: Anthony Blaom, PhD <anthony.blaom@gmail.com>
ablaom
reviewed
Feb 21, 2024
ablaom
reviewed
Feb 21, 2024
ablaom
reviewed
Feb 21, 2024
ablaom
reviewed
Feb 21, 2024
ablaom
reviewed
Feb 21, 2024
ablaom
reviewed
Feb 21, 2024
Co-authored-by: Anthony Blaom, PhD <anthony.blaom@gmail.com>
ablaom
reviewed
Feb 28, 2024
| recursive feature elimination should return the first columns as important features. | ||
| ```julia | ||
| using MLJ # or, minimally, `using FeatureSelection, MLJModels, MLJBase` | ||
| using MLJ, FeatureSelection |
There was a problem hiding this comment.
I am proposing that FeatureSelection be a dep of MLJ with all names re-exported. So you won't need FeatureSelection here, right?
ablaom
reviewed
Feb 28, 2024
| println(io, "$(name)=$(value)") | ||
| end | ||
| end | ||
| event_name = "${{ github.event_name }}" |
There was a problem hiding this comment.
maybe we can just dump all the documenter.jl stuff since we are not using it. in any case, i don't think we need all that complicated logic for this package.
ablaom
reviewed
Feb 28, 2024
ablaom
reviewed
Feb 28, 2024
ablaom
approved these changes
Feb 28, 2024
Co-authored-by: Anthony Blaom, PhD <anthony.blaom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts the process of implementation of Feature Selection models for use with the MLJ package. For now the following models are implemented.
RecursiveFeatureEliminationFeatureSelectorIn the future, more models will be added based on user requests.