Skip to content

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Feb 19, 2020

  • (bug) Remove multithreading race conditions in resampling (use of evaluate!) (Error with evaluate! tests in the distributed setting #169)

  • (testing) Fix and re-instate all CPUThreads and CPUProcesses tests in resampling

  • (enhancement) Add progress meter to all forms of accelerated resampling

  • (testing) Increase number of workers in travis testing to 2 (3 processes); increase number of threads to 2.

@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #202 into master will increase coverage by 2.21%.
The diff coverage is 70.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage    80.9%   83.11%   +2.21%     
==========================================
  Files          31       31              
  Lines        1985     2008      +23     
==========================================
+ Hits         1606     1669      +63     
+ Misses        379      339      -40
Impacted Files Coverage Δ
src/MLJBase.jl 100% <ø> (ø) ⬆️
src/resampling.jl 88.55% <70.73%> (+1.23%) ⬆️
src/parameter_inspection.jl 100% <0%> (ø) ⬆️
src/composition/arrows.jl 25% <0%> (ø) ⬆️
src/hyperparam/one_dimensional_ranges.jl 95.12% <0%> (ø) ⬆️
src/composition/networks.jl 68.94% <0%> (ø) ⬆️
src/equality.jl 90.9% <0%> (ø) ⬆️
src/utilities.jl 75% <0%> (ø) ⬆️
src/show.jl 16.03% <0%> (ø) ⬆️
src/distributions.jl 84.31% <0%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07be1b5...39c7058. Read the comment docs.

@ablaom ablaom merged commit 2b87398 into master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants