-
Notifications
You must be signed in to change notification settings - Fork 0
Fix encoder output types #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EssamWisam
commented
May 12, 2025
EssamWisam
commented
May 12, 2025
Merging this should close #20 |
ablaom
reviewed
May 12, 2025
ablaom
reviewed
May 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this and adding all the new tests.
Based on normalize, we may want integers or floats so let's give this flexibility
ablaom
approved these changes
May 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go, thanks again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that most encoder or transformers implemented in here were subject to the bug mentioned in FluxML/MLJFlux.jl#275 . This PR attempts to fix the output types for all the encoder/transformer methods implemented in this package.
In doing so, adherence to the following performance tip in the Julia doc was considered:
which can be observed in the target, frequency and ordinal encoder changes. It could be helpful to consider changes commit by commit.