🦙 Missingness encoder is here #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ablaom
reviewed
Jul 28, 2024
ablaom
reviewed
Jul 28, 2024
ablaom
reviewed
Jul 28, 2024
ablaom
reviewed
Jul 28, 2024
ablaom
reviewed
Jul 28, 2024
ablaom
reviewed
Jul 28, 2024
| The fields of `fitted_params(mach)` are: | ||
| - `new_cat_given_col_val`: A dictionary that for each column, maps `missing` into some value according to `label_for_missing` |
There was a problem hiding this comment.
Can we call this label_for_missing_given_feature` or similar? See my comments in the contrast encoding PR.
ablaom
reviewed
Jul 28, 2024
ablaom
reviewed
Jul 28, 2024
Co-authored-by: Anthony Blaom, PhD <anthony.blaom@gmail.com>
Co-authored-by: Anthony Blaom, PhD <anthony.blaom@gmail.com>
|
Addressed all points and will merge. Thank you so much for the nice review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the missingness encoder. It shares an implementation/testing framework very similar to the cardinality reducer.