Skip to content

Conversation

jbrea
Copy link
Collaborator

@jbrea jbrea commented Oct 31, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2021

Codecov Report

Merging #14 (9275049) into dev (1a11b2a) will increase coverage by 0.70%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #14      +/-   ##
==========================================
+ Coverage   33.82%   34.53%   +0.70%     
==========================================
  Files           1        1              
  Lines         136      139       +3     
==========================================
+ Hits           46       48       +2     
- Misses         90       91       +1     
Impacted Files Coverage Δ
src/data.jl 34.53% <20.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a11b2a...9275049. Read the comment docs.

@jbrea
Copy link
Collaborator Author

jbrea commented Nov 22, 2021

@ablaom this should be ready now.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbrea Thanks for this and the other improvements.

I agree this should be marked breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants