Skip to content

Conversation

jbrea
Copy link
Collaborator

@jbrea jbrea commented Aug 31, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #8 (00bb922) into dev (14c7da5) will increase coverage by 2.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev       #8      +/-   ##
==========================================
+ Coverage   31.96%   34.35%   +2.38%     
==========================================
  Files           1        1              
  Lines         122      131       +9     
==========================================
+ Hits           39       45       +6     
- Misses         83       86       +3     
Impacted Files Coverage Δ
src/data.jl 34.35% <100.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c7da5...00bb922. Read the comment docs.

@jbrea
Copy link
Collaborator Author

jbrea commented Sep 1, 2021

I think this is ready to be merged, although the compatibility with v1.0 is a bit ugly...

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Many thanks!

@ablaom ablaom merged commit 8fb4a34 into JuliaAI:dev Sep 8, 2021
@ablaom ablaom mentioned this pull request Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants