Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to type-based insurances instead of functional #41

Merged
merged 22 commits into from
Nov 9, 2020

Conversation

alecloudenback
Copy link
Member

closes #40

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #41 (a7ddf05) into master (70b2f71) will increase coverage by 0.56%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   89.51%   90.07%   +0.56%     
==========================================
  Files           2        2              
  Lines         143      131      -12     
==========================================
- Hits          128      118      -10     
+ Misses         15       13       -2     
Flag Coverage Δ
unittests 90.07% <97.43%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/LifeContingencies.jl 96.72% <97.43%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70b2f71...6c368f7. Read the comment docs.

@alecloudenback alecloudenback marked this pull request as draft October 29, 2020 11:37
@alecloudenback alecloudenback mentioned this pull request Oct 29, 2020
@alecloudenback
Copy link
Member Author

Would like to retain a kind of null or zero concept. E.g. an annuity with zero payments. How best to represent?
Ideas:

  • return empty arrays
  • a new struct that is an empty contract

@alecloudenback alecloudenback reopened this Nov 9, 2020
@alecloudenback alecloudenback marked this pull request as ready for review November 9, 2020 13:41
@alecloudenback alecloudenback merged commit 49dfbfe into master Nov 9, 2020
@alecloudenback alecloudenback deleted the refactor2020 branch November 9, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Refactor
1 participant