Fix ReinterpretArray's definition of strides #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nterface's meaning
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 84.38% 84.53% +0.14%
==========================================
Files 11 11
Lines 1531 1545 +14
==========================================
+ Hits 1292 1306 +14
Misses 239 239
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be inline with ArrayInterface's meaning (i.e., about memory layout), rather than use size_of_strides like Base Julia.
Using
size_to_stridescauses LoopVectorization to get incorrect answers whenreinterpretingSubArrays.