have axes(reinterpret(reshape,T,::AbstractArray{S}),1) be static sometimes #198
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) > sizeof(T) return a static range
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 85.23% 85.08% -0.16%
==========================================
Files 11 11
Lines 1666 1669 +3
==========================================
Hits 1420 1420
- Misses 246 249 +3
Continue to review full report at Codecov.
|
Tokazama
reviewed
Aug 31, 2021
| if _is_reshaped(typeof(A)) && (sizeof(S) > sizeof(T)) && dim == 1 | ||
| return One():static(div(sizeof(S), sizeof(T))) | ||
| end | ||
| Base.axes(A, Int(dim)) # TODO implement ArrayInterface version |
There was a problem hiding this comment.
This is calling Base.axes, not defining it.
There was a problem hiding this comment.
Sorry. Was thrown off by spacing in mobile view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where sizeof(S) > sizeof(T) return a static range