Avoid ind2sub in view with Block{1} #268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the internal function
_ind2sub
in constructing views ofAbstractBlockArray
s with oneBlock{1}
index, and instead, indexes into aBlockRange
to get the block index. As a consequence, aBlockBoundsError
is changed to aBoundsError
, but the error message is actually improved.On master
This PR
The main part of the message is that the index
[1,4]
is changed to[10]
. The[1,4]
arises from a lack of bounds-checking in_ind2sub
, and might be tricky to trace back.Secondly, this PR introduces a constructor for
BlockRange
that accepts integer block sizes. This parallelsCartesianIndices
: