Fix path params uri unescape #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmaykm
requested changes
May 30, 2023
| @@ -260,7 +260,7 @@ function prep_args(ctx::Ctx) | |||
| body = to_json(ctx.body) | |||
| elseif ("application/x-www-form-urlencoded" == ctx.header["Content-Type"]) && isa(ctx.body, Dict) | |||
| body = URIs.escapeuri(ctx.body) | |||
| elseif isa(ctx.boody, APIModel) && isempty(get(ctx.header, "Content-Type", "")) | |||
| elseif isa(ctx.body, APIModel) && isempty(get(ctx.header, "Content-Type", "")) | |||
There was a problem hiding this comment.
oops! thanks for catching this
|
GitHub CI with Julia 1.9 is having trouble. Testing locally shows no trouble with 1.9 though. Will merge this and we can look into that separately |
tanmaykm
added a commit
that referenced
this pull request
May 31, 2023
Update tests for #28. Add some diagnostic messages to troubleshoot CI.
Merged
|
Great! Thanks for testing it out. |
tanmaykm
added a commit
that referenced
this pull request
May 31, 2023
Update tests for #28. Add some diagnostic messages to troubleshoot CI.
tanmaykm
added a commit
that referenced
this pull request
May 31, 2023
Update tests for #28. Add some diagnostic messages to troubleshoot CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fix #27
Dunno, have to test it first.