Skip to content

Add support for multipart/form-data POST data parsing #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 21, 2023
Merged

Conversation

krynju
Copy link
Member

@krynju krynju commented Jul 14, 2023

I'm patching a use case I have for now, but I can see there is some code to handle this, but it's based on a Dict
What I'm getting is a vector of multparts from HTTP.jl so just adding support for this - not sure what the Dict handling is for.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Merging #41 (d62d837) into main (ab990fc) will decrease coverage by 2.44%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   78.06%   75.63%   -2.44%     
==========================================
  Files           7        7              
  Lines         497      513      +16     
==========================================
  Hits          388      388              
- Misses        109      125      +16     
Impacted Files Coverage Δ
src/server.jl 55.73% <0.00%> (-19.82%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tanmaykm added 4 commits July 20, 2023 20:02
- client and server handling of multipart/form-data
- update test to add petstore upload_file
- add tests for forms
client and server handling of multipart/form-data
Updated test code to test required form params. Test code re-generated with fixed codegen.
Bumped version in prep for tagging
also test required form param condition
@tanmaykm tanmaykm marked this pull request as ready for review July 21, 2023 08:49
@tanmaykm tanmaykm merged commit a12ba5a into main Jul 21, 2023
@delete-merged-branch delete-merged-branch bot deleted the kr/multipart branch July 21, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants