Skip to content

Make it work with any iterable table #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

davidanthoff
Copy link
Contributor

I think that should be enough to make it work directly with all sources that support the IterableTables.jl interface. But, someone better try it, because this is done blind, i.e. I didn't have the time right now to figure out the whole WebIO.jl setup issue.

Maybe @piever could try this branch quickly? I think you have everything working?

@piever
Copy link
Contributor

piever commented Feb 22, 2018

You need to install nodejs, then run:

using WebIO
WebIO.devsetup()
WebIO.bundlejs(watch=false)

Your branch works! At least for DataFrames and vector of NamedTuples.

Two slightly unrelated feedbacks:

  • Changing values in the spreadsheet does not change the data table, which is confusing
  • DataValues are represented by the string [object Object] (when the data is present): I guess they need some sort of special method

@davidanthoff
Copy link
Contributor Author

This package is just generally a read-only view, right? Or does it propagate edits back into IndexedTables?

Either of the two PRs would fix the DataValue issue (and both should be merged): #5 and JuliaData/IndexedTables.jl#108.

@piever
Copy link
Contributor

piever commented Feb 22, 2018

Glad to know the DataValue part is soon fixed. About the changing values: I got confused because I'm allowed to edit the spreadsheet (I think in matlab that means you're actually changing the data). I guess one should either change the data or disallow the edits (sorry for the Off-Topic).

@shashi shashi merged commit 08f035e into JuliaComputing:master Jun 12, 2018
@davidanthoff davidanthoff deleted the iterabletables branch June 12, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants