Skip to content

Conversation

jakubwro
Copy link
Collaborator

@jakubwro jakubwro commented Dec 8, 2019

  1. I suggest to create sub folders for each method in doc/src.
  2. White frames in jpg do not look good in dark theme, markdown tables seem to be better.
  3. I cannot run doc/src/wiener/time-series.jl. I understand that I need older version of Julia to run that, I think it is better to upgrade LombScargle.jl to support the newest environment. If you agree I can contribute there.
(v1.2) pkg> add LombScargle
  Updating registry at `~/.julia/registries/General`
  Updating git-repo `https://github.com/JuliaRegistries/General.git`
 Resolving package versions...
ERROR: Unsatisfiable requirements detected for package LombScargle [fc60dff9]:
 LombScargle [fc60dff9] log:
 ├─possible versions are: 0.4.0 or uninstalled
 ├─restricted to versions * by an explicit requirement, leaving only versions 0.4.0
 └─restricted by compatibility requirements with FFTW [7a1cc6ca] to versions: uninstalled — no versions left
   └─FFTW [7a1cc6ca] log:
     ├─possible versions are: [0.1.0-0.1.2, 0.2.0-0.2.4, 0.3.0, 1.0.0-1.0.1, 1.1.0] or uninstalled
     ├─restricted to versions [0.0.0-0.0, 0.1.0-0.1, 0.2.0-0.2, 0.3.0-0.3, 1.0.0-1] by Deconvolution [41ba435c], leaving only versions [0.1.0-0.1.2, 0.2.0-0.2.4, 0.3.0, 1.0.0-1.0.1, 1.1.0]
     │ └─Deconvolution [41ba435c] log:
     │   ├─possible versions are: 0.3.0 or uninstalled
     │   └─Deconvolution [41ba435c] is fixed to version 0.3.0
     └─restricted to versions 1.1.0 by an explicit requirement, leaving only versions 1.1.0

@codecov-io
Copy link

codecov-io commented Dec 8, 2019

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #13   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          25     25           
=====================================
  Hits           25     25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 655f59f...6845efc. Read the comment docs.

@jakubwro
Copy link
Collaborator Author

jakubwro commented Dec 8, 2019

@giordano after executing line below I was able to run the script. Some changes were required to make it work, please see the last commit.

(v1.2) pkg> dev https://github.com/JuliaAstro/LombScargle.jl

@giordano
Copy link
Member

giordano commented Dec 8, 2019

Thanks for taking care of this! I'm updating LombScargle so that it can be properly installed, it didn't have a Project.toml

@jakubwro
Copy link
Collaborator Author

jakubwro commented Dec 8, 2019

Thanks for taking care of this! I'm updating LombScargle so that it can be properly installed, it didn't have a Project.toml

I needed to do something simple after working whole weekend on this NTT stuff without much progress :)

@giordano
Copy link
Member

giordano commented Dec 8, 2019

Ok, LombScargle should now be installable

@jakubwro
Copy link
Collaborator Author

jakubwro commented Dec 9, 2019

Ok, LombScargle should now be installable

I confirm, it woks with "add" after updating General registry. Anyway generated plots are slightly different, I think caused by changes in Plots.jl

@giordano giordano merged commit 7af04b8 into JuliaDSP:master Jan 1, 2020
@jakubwro jakubwro deleted the doc-structure branch January 1, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants