-
Notifications
You must be signed in to change notification settings - Fork 11
Added Richardson-Lucy deconvolution #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wow, this is great, thank you very much! I'll review later. This PR also reminds me that I should move documentation to Documenter 😓 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot comment on the algorithm in particular as I'm not familiar with it, but the code looks good, thank you so much!
If you think it's worth merging I'll update docs.
Yes, please 🙂
Co-Authored-By: Mosè Giordano <giordano@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 3 +1
Lines 16 25 +9
=====================================
+ Hits 16 25 +9
Continue to review full report at Codecov.
|
Hi @giordano , I added docs and more illustrative usage example |
Awesome, I'll have a look in the next few days! |
@giordano, I readded docs, but I have a feeling that messed something with git #history. Please have a look. |
The history is not a problem, we can just squash everything 😉 I followed your struggle, I'm really sorry for this. I can feel your pain, I had similar problems a few days ago. In theses cases I think that it's easier to do a clean merge of the target branch on yours rather than rebasing. |
*.jl.*.cov | ||
*.jl.mem | ||
/doc/_build/ | ||
/doc/build/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhishalya , Documenter uses different output folder and .gitignore should be changed. Sorry for not catching that during review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right. Sorry I missed that too. Thanks for correcting that :)
Right, it's not the first time I have this problem with rebase. |
Documentation is available at https://juliadsp.github.io/Deconvolution.jl/dev/. Thank you so much @jakubwro and @abhishalya! This new method looks very good! |
Hi, please review. If you think it's worth merging I'll update docs.