Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove disambiguation prefix #1245

Merged
merged 1 commit into from
Oct 9, 2017
Merged

Remove disambiguation prefix #1245

merged 1 commit into from
Oct 9, 2017

Conversation

cjprybol
Copy link
Contributor

@cjprybol cjprybol commented Oct 9, 2017

I think this was to get rid of a warning/error when a dependency of DataTables also imported DataFrames and the names conflicted? Either way, we don't need it anymore

@cjprybol
Remove disambiguation prefix
cce9f73 
I think this was to get rid of a warning/error when a dependency of `DataTables` also imported `DataFrames` and the names conflicted? Either way, we don't need it anymore
@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.552% when pulling cce9f73 on cjprybol-patch-1 into eb3d10a on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.552% when pulling cce9f73 on cjprybol-patch-1 into eb3d10a on master.

nalimilan
nalimilan approved these changes Oct 9, 2017
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's from the time when it was defined in DataArrays.

@cjprybol cjprybol merged commit 8fd0851 into master Oct 9, 2017
@cjprybol cjprybol deleted the cjprybol-patch-1 branch October 9, 2017 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjprybol @coveralls @nalimilan