Deprecate use of categorical! function on non-AbstractString columns #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
reviewed
Oct 12, 2017
| @@ -740,20 +740,28 @@ end | |||
| ############################################################################## | |||
|
|
|||
| function categorical!(df::DataFrame, cname::Union{Integer, Symbol}) | |||
| df[cname] = CategoricalVector(df[cname]) | |||
| if Nulls.T(eltype(df[cname])) <: AbstractString | |||
There was a problem hiding this comment.
Instead of adding this deprecation here, I'd rather do that directly in CategoricalArrays. That way we have only one deprecation to remove once we decide the deprecation period is over.
|
Waiting on (post-merge) discussions on what types to support in CategoricalArrays here -> JuliaData/CategoricalArrays.jl#77 |
|
With JuliaData/CategoricalArrays.jl#87, I guess we can keep the current behavior which converts all columns to |
|
Yes! Very exciting to see JuliaData/CategoricalArrays.jl#87 get merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1250