Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup tests #1931

Merged
merged 1 commit into from
Sep 1, 2019
Merged

Cleanup tests #1931

merged 1 commit into from
Sep 1, 2019

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Aug 26, 2019

What I have changed:

  • added tests for DataFrame constructors from eachrow and eachcol as they were missing
  • removed "error" word from testset names, so that they do not produce false positives when parsing log files.

@bkamins
Copy link
Member Author

bkamins commented Aug 26, 2019

@quinnj - you might want to have a look at tests of eachrow and eachcol constructors - I guess they behave exactly as you have designed Tables.jl, but please confirm. Thank you.

quinnj
quinnj approved these changes Aug 26, 2019
View reviewed changes
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkamins bkamins merged commit 6bdfee8 into JuliaData:master Sep 1, 2019
@bkamins bkamins deleted the cleanup_tests branch September 1, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkamins @nalimilan @quinnj