(WIP) preparation for Julia 0.6 #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
requested changes
Feb 18, 2017
There was a problem hiding this comment.
I don't think it's appropriate to require 0.6 here yet. Nothing used in this package will be broken by language changes in 0.6, it will only emit a few deprecation warnings, which can easily be fixed using Compat. It doesn't matter that newer versions of DataArrays will require 0.6--that's why we have all of the version requirement resolution machinery in Pkg.
|
thanks for the review. using Compat would be better! |
|
No need to close the PR, though. Most of these changes can and need to be applied, just with |
|
I have no problem at all with dropping support for Julia 0.4. |
|
yeah, it's good to support julia 0.5 with Compat. |
|
close this PR by #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the master branch of the DataArrays has depended on Julia 0.6-.
and getting work with DataFrames PR #1164.