Allow bytearrays to be stored as BLOBs #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any object that is serialized is now put in a Serialization type then serialized. When sqldeserialize is called on a bytearray, it checks whether the deserialized array is a Serialization and if so returns the object it holds, otherwise returning the array.
sqlreturn(::Any, ::Vector{UInt8}) was serializing values so any values passed to
sqlreturn(::Any, ::Any) were being serialized twice. The net result of this
being that they were returned as bytearrays.
|
Changes Unknown when pulling f5b4876 on iss50 into * on master*. |
quinnj
added a commit
that referenced
this pull request
Nov 18, 2014
Allow bytearrays to be stored as BLOBs
|
This looks great. I'm merging now so I can play with it locally. |
|
Ok, check out my latest commit 42e6598 and see what you think. I think the performance hit of a try-catch would be pretty bad inside of the I also added some commits to help things pass on 0.3 release, though I didn't actually do any testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50.
The idea's fairly simply;
Vector{UInt8}s get stored directly into BLOBS, any other object gets wrapped in aSerializationobject, serialized then stored as a BLOB. When they're deserialized the Array gets returned unchanged unless the deserialized value is aSerializationin which case the object which theSerializationholds gets returned.Obviously the array could happen to match a
Serializationeven when if hasn't been serialized but I think this is such an unlikely corner case that it shouldn't matter too much.