Skip to content

Conversation

serenity4
Copy link
Collaborator

@serenity4 serenity4 commented Jun 10, 2025

#140 introduced a breaking change to the method_info data structure, requiring a breaking release.

We had thought of deferring this breaking release until a new change to Revise that may require breaking changes. See timholy/Revise.jl#904 (comment) for context on the opening of this PR.

@serenity4 serenity4 requested a review from timholy June 10, 2025 14:06
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (c0ca2ff) to head (eec94b7).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   69.60%   69.60%           
=======================================
  Files           3        3           
  Lines         408      408           
=======================================
  Hits          284      284           
  Misses        124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timholy
Copy link
Member

timholy commented Jun 14, 2025

I should have some time by mid-week next week. I'd like to get the include(mappingfunc, filename) change in too, but then let's make the release.

@serenity4
Copy link
Collaborator Author

serenity4 commented Jun 19, 2025

Here are my changes (still very WIP) for mapexpr, FYI: serenity4/Revise.jl@master...mapexpr

I also don't mind waiting until I find some time to finish it, if you have a strong preference toward having both in before issuing a breaking release.

@timholy
Copy link
Member

timholy commented Jul 24, 2025

I've verified that we can add include(mapexpr, file) support in a non-breaking way. However, we first need to decide whether we want #141, which would be breaking. So sadly we need to hold this just a tiny bit longer. Sorry for the unconscionable delay!

@serenity4 serenity4 merged commit 84c7309 into JuliaDebug:master Jul 24, 2025
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants