Skip to content

Conversation

oxinabox
Copy link
Member

@oxinabox oxinabox commented Mar 8, 2021

example output

julia> test_rrule(two2three, 3.33, -7.77)
Test Summary:                          | Pass  Total
test_rrule: two2three at (3.33, -7.77) |    6      6
Test.DefaultTestSet("test_rrule: two2three at (3.33, -7.77)", Any[Test.DefaultTestSet("Don't thunk only non_zero argument", Any[], 0, false)], 6, false)

Closes #121 and #108

I recomment turning on "hide whitespace changes" when reviewing,
since this indented a ton of code without changing it


image

@oxinabox
Copy link
Member Author

oxinabox commented Mar 8, 2021

oh boy this breaks a lot of our unhappy path tests

@oxinabox
Copy link
Member Author

oxinabox commented Mar 8, 2021

Ok, most of this PR is now improving out meta-testing ability

NonPassingTestset(desc) = NonPassingTestset(desc, [])

# Records nothing, and throws an error immediately whenever a Fail or
# Error occurs. Takes no action in the event of a Pass or Broken result
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Error occurs. Takes no action in the event of a Pass or Broken result

Copy link
Contributor

@nickrobinson251 nickrobinson251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As far as i understand this implements a AbstractTestSet as intended, and this seems a nice useage

oxinabox and others added 4 commits March 9, 2021 11:23
Co-authored-by: Nick Robinson <npr251@gmail.com>
Co-authored-by: Nick Robinson <npr251@gmail.com>
Co-authored-by: Nick Robinson <npr251@gmail.com>
@oxinabox
Copy link
Member Author

oxinabox commented Mar 9, 2021

As far as i understand this implements a AbstractTestSet as intended, and this seems a nice useage

Yeah, i think this is much nicer than before. And I couldn'tt workout how to handle errors the otherway.
A benifit i didn't realize of doing it this way is that we don't need to mute anymore.
Because the printlns I was hiding were all actually triggered by record
being unmuted means i can insert println debugging messages.

@oxinabox oxinabox merged commit d19d7a5 into master Mar 9, 2021
@oxinabox oxinabox deleted the ox/out branch March 9, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_rrule says that it didn't run any tests
2 participants