-
Notifications
You must be signed in to change notification settings - Fork 17
wrap testers in top level testset #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
oh boy this breaks a lot of our unhappy path tests |
Ok, most of this PR is now improving out meta-testing ability |
test/meta_testing_tools.jl
Outdated
NonPassingTestset(desc) = NonPassingTestset(desc, []) | ||
|
||
# Records nothing, and throws an error immediately whenever a Fail or | ||
# Error occurs. Takes no action in the event of a Pass or Broken result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Error occurs. Takes no action in the event of a Pass or Broken result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As far as i understand this implements a AbstractTestSet as intended, and this seems a nice useage
Co-authored-by: Nick Robinson <npr251@gmail.com>
Co-authored-by: Nick Robinson <npr251@gmail.com>
Co-authored-by: Nick Robinson <npr251@gmail.com>
Yeah, i think this is much nicer than before. And I couldn'tt workout how to handle errors the otherway. |
example output
Closes #121 and #108
I recomment turning on "hide whitespace changes" when reviewing,
since this indented a ton of code without changing it