Skip to content

Conversation

sethaxen
Copy link
Member

The workflows are based on those from ChainRules.jl. Since we don't build documentation or compute code coverage with Travis, I didn't add those in this PR.

@oxinabox
Copy link
Member

Looks like fails on Julia-latest would be fixed by
#72

But also i think we should stop testing on the latest julia

@sethaxen
Copy link
Member Author

Looks like fails on Julia-latest would be fixed by
#72

But also i think we should stop testing on the latest julia

Do you mean JuliaNightly? I went ahead and removed that workflow.

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets also delete Travis CI in this PR

@sethaxen
Copy link
Member Author

Done. Also I just realized that there was a Documenter stage with Travis, but it's been broken since Julia 1.5, so I added a corresponding GitHub actions workflow.

@sethaxen
Copy link
Member Author

sethaxen commented Dec 17, 2020

Weird, Julia 1.0 (Edit: and Julia 1) tests just started failing. @mzgubic @oxinabox is this due to #87?

@oxinabox
Copy link
Member

Weird, Julia 1.0 (Edit: and Julia 1) tests just started failing. @mzgubic @oxinabox is this due to #87?

Looks related.
Let me pull branches and test locally

@oxinabox
Copy link
Member

yes, I have reproduced that locally, I am not sure the root cause but it seems like it does not block this PR.
what ever it is, seems like we can attribute bad code being merged to CI not running
Lets merge this PR now so it stops from happenning again

@oxinabox oxinabox merged commit 341ff10 into master Dec 17, 2020
@oxinabox oxinabox deleted the ghactionsci branch December 17, 2020 20:32
oxinabox pushed a commit that referenced this pull request Dec 17, 2020
* Add GitHub Actions CI workflows

* Add CI badge

* Remove JuliaNightly workflow

* Remove Travis

* Add documenter workflow

* Add documenter key

* Move to correct directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants