-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: AD stuff #22
WIP: AD stuff #22
Conversation
PR is in reasonable shape now, so probably time for a review before polishing. Things to address:
|
Sweet, I'll try to review this this week. Also interested in thoughts from @MikeInnes and @dfdx, if they have any.
Nah, we can bump to 1.0 whenever.
Would be good to know why but not essential at the moemnt |
Most recent PR begins porting stuff over from DiffLinearAlgebra. See |
What's the status of this PR? Is this change still relevant going forward in the current Julia AD landscape? If so, I can try to help get it cleaned up. |
This is PR is basically dead given ChainRules.jl as far as I'm concerned. I'm happy for this to be closed. |
Work in progress PR to extent DiffRules to provide useful AD-related functionality. The scope of the additions include:
Initial commit:
@define_diffrule
macro to improve readability using MacroTools.ToDo:
wrt
API. See Supporting Linear Algebraic Primitives #10. Requires a more structured representation of the rules than I currently provide.Unknowns: