Skip to content
This repository was archived by the owner on Mar 11, 2022. It is now read-only.

Conversation

junyuan-chen
Copy link
Member

To specify arguments required by each StatsStep, the previous practice is to define new methods for namedargs. The returned NamedTuple is then passed to _getargs.

The improved design proposed here mainly make the following changes:

  1. Rename _getargs to groupargs for more accurate description of its role.
  2. Replace namedargs with three new functions that cover most scenarios: required, default and transformed.

@junyuan-chen junyuan-chen added the enhancement New feature or request label Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #4 (bb86668) into master (b4efeff) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files           8        8           
  Lines         459      465    +6     
=======================================
+ Hits          457      463    +6     
  Misses          2        2           
Impacted Files Coverage Δ
src/DiffinDiffsBase.jl 100.00% <ø> (ø)
src/StatsProcedures.jl 99.18% <100.00%> (+0.01%) ⬆️
src/procedures.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4efeff...5fda57d. Read the comment docs.

@junyuan-chen junyuan-chen merged commit 5e95259 into master Feb 4, 2021
@junyuan-chen junyuan-chen deleted the pr/args branch February 4, 2021 04:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant