-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document makedocs
argument pages
for LaTeX output
#2431
Conversation
Actually, I'm leaning towards considering this a bug. IIRC, for HTML we do populate
I would be okay merging this doc note if we make it clear that it's a bug. But it would be good to also check why the documented behavior is not working -- it might be a simple fix. |
In my case, changing the following lines from Documenter.jl/src/latex/LaTeXWriter.jl Lines 115 to 116 in 233a782
to if isempty(doc.user.pages)
@warn "No pages found. Using doc.internal.navlist for retrieving pages."
contextpages = [i.page for i in doc.internal.navlist]
else
contextpages = doc.user.pages
end
writeheader(context, doc, settings)
for (title, filename, depth) in files(contextpages) seems to fix the problem. But I'm not sure how to properly test the code, neither do I know if it is safe to use |
Update: I am able to build the whole Documenter.jl documents with the tweak above, by:
Hope this is helpful. |
Could you try adding another test build that looks like this, but doesn't specify Documenter.jl/test/examples/make.jl Lines 829 to 847 in d521d5a
It should ideally pick up the It would also need a corresponding test here, and maybe we can even reuse the Documenter.jl/test/examples/tests.jl Lines 340 to 349 in d521d5a
|
Hmm. In Documenter.jl/src/html/HTMLWriter.jl Lines 695 to 699 in d521d5a
Maybe if we use that instead of |
Let's merge this as is, since it can be useful for users. We can fix the behavior in a follow-up PR. |
Trying to fix #2132.