Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong image.path (#2434) #2440

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChromatinRemodeling
Copy link
Contributor

No description provided.

@mortenpi
Copy link
Member

mortenpi commented Feb 5, 2024

Like in #2431 (comment), it would be good to have a test here that would also run on Windows. Modifying the texonly test should be sufficient.

Note: you should be able to set the DOCUMENTER_FIXTESTS environment variable to automatically update the reference .tex files:

function compare_files(a, b)
if haskey(ENV, "DOCUMENTER_FIXTESTS")
@info "Updating reference file: $(b)"
cp(a, b, force=true)
end
a_str, b_str = read(a, String), read(b, String)
a_str_normalized, b_str_normalized = onormalize_tex(a_str), onormalize_tex(b_str)
a_str_normalized == b_str_normalized && return true
@error "Generated files did not agree with reference, diff follows." a b
printdiff(a_str_normalized, b_str_normalized)
println('='^40, " end of diff ", '='^40)
return false
end

@mortenpi mortenpi added Format: LaTeX Related to the LaTeX / PDF output Type: Bugfix labels Feb 5, 2024
@ChromatinRemodeling ChromatinRemodeling marked this pull request as draft February 16, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: LaTeX Related to the LaTeX / PDF output Type: Bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants