-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New outcome space and encoding: BubbleSortSwaps
and BubbleSortSwapsEncoding
#390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameters must be defined inside test set
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
==========================================
+ Coverage 88.80% 89.00% +0.20%
==========================================
Files 82 85 +3
Lines 2393 2447 +54
==========================================
+ Hits 2125 2178 +53
- Misses 268 269 +1 ☔ View full report in Codecov by Sentry. |
Datseris
reviewed
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only minor comments
Co-authored-by: George Datseris <datseris.george@gmail.com>
Co-authored-by: George Datseris <datseris.george@gmail.com>
Co-authored-by: George Datseris <datseris.george@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #384.
BubbleSortSwaps
outcome space, which when used to encode data, first embeds the data, then counts for each state vector the number of swaps necessary for the bubble sort algorithm to sort it.BubbleSortSwapsEncoding
, which takes care of the actual encoding.codify
, which usesBubbleSortSwapsEncoding
and is used internally byBubbleSortSwaps
.BubbleEntropy <: ComplexityEstimator
, which implements bothcomplexity
andcomplexity_normalized
, and computes a (normalized) difference between entropies for dimensionsm + 1
andm
. In the original paper, Renyi entropy of orderq = 2
was used, but thanks toinformation_maximum
, we can use anyInformationMeasure
.