Fix duplicate prefix for produce_or_load(; filename)

[jonas-schulze]

Removing mentioned line did not work, as that would break usages like produce_or_load(; filename=hash, prefix="foo"). We could make append_prefix_suffix() a little more fuzzy, but that would invalidate other cache files.

Let me describe my use case: I just wanted to replace the savename(; connector) to have the cache file names a little more readable. According to the documentation, I could simply use produce_or_load(; kwargs...) for that purpose. Upon doing so, the warning told me to use the filename kwarg instead, which led me to the duplicated prefix described in #392 (comment). Maybe one should set the inner prefix="". What do you think?

Having looked into the code, another issue popped up: should append_prefix_suffix() adhere to savename(; connector)? Currently, it uses _ regardless.

Fix #392

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cad2a38) 90.65% compared to head (74fe134) 90.65%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   90.65%   90.65%           
=======================================
  Files           8        8           
  Lines         760      760           
=======================================
  Hits          689      689           
  Misses         71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jonas-schulze]

The failures look unrelated.