Revert "Use create-pull-request v2 (#164)" #167

tkf · 2020-01-18T05:14:41Z

With create-pull-request v2, pkg-update.yml fails with message

Working base branch 'create-pull-request/pkg-update' was created
by this action.

See, e.g.,
https://github.com/tkf/Transducers.jl/commit/f355ead83998dc51359a3df695dde1b3aa3ad13c/checks?check_suite_id=407542139#step:8:46

It looks like this check is added in v2:
peter-evans/create-pull-request@b7565b8#diff-574590219ffa8e6059b434d8f8a5273cR87-R95

Let's keep using v1 for now.

This reverts commit f355ead.

With create-pull-request v2, pkg-update.yml fails with message Working base branch 'create-pull-request/pkg-update' was created by this action. See, e.g., https://github.com/tkf/Transducers.jl/commit/f355ead83998dc51359a3df695dde1b3aa3ad13c/checks?check_suite_id=407542139#step:8:46 It looks like this check is added in v2: peter-evans/create-pull-request@b7565b8#diff-574590219ffa8e6059b434d8f8a5273cR87-R95 Let's keep using v1 for now. This reverts commit f355ead.

See also: JuliaFolds/Transducers.jl#167 This reverts commit 1f2c90b.

codecov-io · 2020-01-18T05:16:56Z

Codecov Report

Merging #167 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   93.84%   93.67%   -0.17%     
==========================================
  Files          19       19              
  Lines        1250     1264      +14     
==========================================
+ Hits         1173     1184      +11     
- Misses         77       80       +3

Impacted Files	Coverage Δ
src/processes.jl	`90.68% <0%> (-1.96%)`	⬇️
src/library.jl	`95.68% <0%> (+0.17%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f355ead...968d86f. Read the comment docs.

github-actions · 2020-01-18T05:26:49Z

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Transducers.jl/Transducers.jl

Job Properties

Time of benchmarks:
- Target: 18 Jan 2020 - 05:23
- Baseline: 18 Jan 2020 - 05:26
Package commits:
- Target: 95c57e
- Baseline: f355ea
Julia commits:
- Target: 2d5741
- Baseline: 2d5741
Julia command flags:
- Target: None
- Baseline: None
Environment variables:
- Target: None
- Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
`["gemm", "mul", "man", "ivdep", "8"]`	1.28 (5%) ❌	1.00 (1%)
`["gemm", "mul", "man", "true", "8"]`	0.87 (5%) ✅	1.00 (1%)
`["gemm", "mul", "xf", "false", "8"]`	1.05 (5%) ❌	1.00 (1%)
`["gemm", "mul", "xf", "ivdep", "8"]`	1.25 (5%) ❌	1.00 (1%)
`["missing_dot", "equiv"]`	0.91 (5%) ✅	1.00 (1%)
`["missing_dot", "rf_nota"]`	0.86 (5%) ✅	1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["cat"]
["collect"]
["dot"]
["filter_map_map!"]
["filter_map_reduce"]
["gemm", "fusedmul", "blas"]
["gemm", "fusedmul", "xf"]
["gemm", "mul", "linalg"]
["gemm", "mul", "man", "false"]
["gemm", "mul", "man", "ivdep"]
["gemm", "mul", "man", "true"]
["gemm", "mul", "xf", "false"]
["gemm", "mul", "xf", "ivdep"]
["gemm", "mul", "xf", "true"]
["missing_argmax"]
["missing_dot"]
["partition_by"]

Julia versioninfo

Target

Julia Version 1.3.1
Commit 2d5741174c (2019-12-30 21:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.3 LTS
  uname: Linux 5.0.0-1027-azure #29~18.04.1-Ubuntu SMP Mon Nov 25 21:18:57 UTC 2019 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      23668 s          0 s       1613 s      31292 s          0 s
       #2  2294 MHz      29104 s          0 s       1826 s      25858 s          0 s
       
  Memory: 6.782737731933594 GB (3421.37109375 MB free)
  Uptime: 582.0 sec
  Load Avg:  1.13623046875  0.98974609375  0.548828125
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, broadwell)

Baseline

Julia Version 1.3.1
Commit 2d5741174c (2019-12-30 21:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.3 LTS
  uname: Linux 5.0.0-1027-azure #29~18.04.1-Ubuntu SMP Mon Nov 25 21:18:57 UTC 2019 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      32389 s          0 s       2258 s      43194 s          0 s
       #2  2294 MHz      43642 s          0 s       2027 s      32392 s          0 s
       
  Memory: 6.782737731933594 GB (3516.4140625 MB free)
  Uptime: 795.0 sec
  Load Avg:  1.14892578125  1.07470703125  0.67724609375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, broadwell)

Target result

Benchmark Report for /home/runner/work/Transducers.jl/Transducers.jl

Job Properties

Time of benchmark: 18 Jan 2020 - 5:23
Package commit: 95c57e
Julia commit: 2d5741
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	memory	allocations
`["cat", "base"]`	205.701 μs (5%)
`["cat", "xf"]`	1.460 μs (5%)
`["collect", "filter-missing"]`	76.601 μs (5%)	33.00 KiB (1%)	17
`["collect", "identity-float"]`	61.400 μs (5%)	256.86 KiB (1%)	17
`["collect", "identity-union"]`	294.102 μs (5%)	285.63 KiB (1%)	6684
`["dot", "blas"]`	2.267 μs (5%)
`["dot", "man"]`	2.256 μs (5%)
`["dot", "rf"]`	2.656 μs (5%)
`["dot", "xf"]`	2.667 μs (5%)
`["filter_map_map!", "man"]`	67.600 μs (5%)
`["filter_map_map!", "xf"]`	69.901 μs (5%)	144 bytes (1%)	8
`["filter_map_reduce", "man"]`	194.901 μs (5%)
`["filter_map_reduce", "xf"]`	194.901 μs (5%)
`["gemm", "fusedmul", "blas", "16"]`	3.431 ms (5%)
`["gemm", "fusedmul", "blas", "2"]`	2.513 ms (5%)
`["gemm", "fusedmul", "blas", "32"]`	5.009 ms (5%)
`["gemm", "fusedmul", "blas", "8"]`	3.042 ms (5%)
`["gemm", "fusedmul", "xf", "16"]`	5.298 ms (5%)	160 bytes (1%)	6
`["gemm", "fusedmul", "xf", "2"]`	604.802 μs (5%)	160 bytes (1%)	6
`["gemm", "fusedmul", "xf", "32"]`	10.656 ms (5%)	160 bytes (1%)	6
`["gemm", "fusedmul", "xf", "8"]`	2.602 ms (5%)	160 bytes (1%)	6
`["gemm", "mul", "linalg", "256"]`	672.004 μs (5%)
`["gemm", "mul", "linalg", "32"]`	3.737 μs (5%)
`["gemm", "mul", "linalg", "8"]`	286.572 ns (5%)
`["gemm", "mul", "man", "false", "256"]`	4.710 ms (5%)
`["gemm", "mul", "man", "false", "32"]`	7.125 μs (5%)
`["gemm", "mul", "man", "false", "8"]`	409.500 ns (5%)
`["gemm", "mul", "man", "ivdep", "256"]`	4.553 ms (5%)
`["gemm", "mul", "man", "ivdep", "32"]`	6.520 μs (5%)
`["gemm", "mul", "man", "ivdep", "8"]`	382.843 ns (5%)
`["gemm", "mul", "man", "true", "256"]`	4.537 ms (5%)
`["gemm", "mul", "man", "true", "32"]`	7.375 μs (5%)
`["gemm", "mul", "man", "true", "8"]`	348.837 ns (5%)
`["gemm", "mul", "xf", "false", "256"]`	4.562 ms (5%)	48 bytes (1%)	2
`["gemm", "mul", "xf", "false", "32"]`	6.860 μs (5%)	48 bytes (1%)	2
`["gemm", "mul", "xf", "false", "8"]`	421.106 ns (5%)	48 bytes (1%)	2
`["gemm", "mul", "xf", "ivdep", "256"]`	4.501 ms (5%)	48 bytes (1%)	2
`["gemm", "mul", "xf", "ivdep", "32"]`	5.950 μs (5%)	48 bytes (1%)	2
`["gemm", "mul", "xf", "ivdep", "8"]`	375.610 ns (5%)	48 bytes (1%)	2
`["gemm", "mul", "xf", "true", "256"]`	4.526 ms (5%)	48 bytes (1%)	2
`["gemm", "mul", "xf", "true", "32"]`	6.840 μs (5%)	48 bytes (1%)	2
`["gemm", "mul", "xf", "true", "8"]`	399.500 ns (5%)	48 bytes (1%)	2
`["missing_argmax", "man"]`	894.595 ns (5%)	32 bytes (1%)	1
`["missing_argmax", "rf"]`	2.200 μs (5%)	32 bytes (1%)	1
`["missing_argmax", "xf"]`	2.189 μs (5%)	32 bytes (1%)	1
`["missing_dot", "equiv"]`	1.230 μs (5%)	16 bytes (1%)	1
`["missing_dot", "man"]`	978.261 ns (5%)	16 bytes (1%)	1
`["missing_dot", "naive"]`	4.029 μs (5%)	16 bytes (1%)	1
`["missing_dot", "rf"]`	849.364 ns (5%)	16 bytes (1%)	1
`["missing_dot", "rf_nota"]`	1.240 μs (5%)	16 bytes (1%)	1
`["missing_dot", "xf"]`	189.801 μs (5%)	74.02 KiB (1%)	3865
`["missing_dot", "xf_nota"]`	184.601 μs (5%)	74.08 KiB (1%)	3864
`["partition_by", "man"]`	1.755 ms (5%)	352 bytes (1%)	4
`["partition_by", "xf"]`	1.667 ms (5%)	576 bytes (1%)	7

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["cat"]
["collect"]
["dot"]
["filter_map_map!"]
["filter_map_reduce"]
["gemm", "fusedmul", "blas"]
["gemm", "fusedmul", "xf"]
["gemm", "mul", "linalg"]
["gemm", "mul", "man", "false"]
["gemm", "mul", "man", "ivdep"]
["gemm", "mul", "man", "true"]
["gemm", "mul", "xf", "false"]
["gemm", "mul", "xf", "ivdep"]
["gemm", "mul", "xf", "true"]
["missing_argmax"]
["missing_dot"]
["partition_by"]

Julia versioninfo

Julia Version 1.3.1
Commit 2d5741174c (2019-12-30 21:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.3 LTS
  uname: Linux 5.0.0-1027-azure #29~18.04.1-Ubuntu SMP Mon Nov 25 21:18:57 UTC 2019 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      23668 s          0 s       1613 s      31292 s          0 s
       #2  2294 MHz      29104 s          0 s       1826 s      25858 s          0 s
       
  Memory: 6.782737731933594 GB (3421.37109375 MB free)
  Uptime: 582.0 sec
  Load Avg:  1.13623046875  0.98974609375  0.548828125
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, broadwell)

Baseline result

Benchmark Report for /home/runner/work/Transducers.jl/Transducers.jl

Job Properties

Time of benchmark: 18 Jan 2020 - 5:26
Package commit: f355ea
Julia commit: 2d5741
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	memory	allocations
`["cat", "base"]`	207.000 μs (5%)
`["cat", "xf"]`	1.460 μs (5%)
`["collect", "filter-missing"]`	77.400 μs (5%)	33.00 KiB (1%)	17
`["collect", "identity-float"]`	59.701 μs (5%)	256.86 KiB (1%)	17
`["collect", "identity-union"]`	298.201 μs (5%)	285.52 KiB (1%)	6665
`["dot", "blas"]`	2.300 μs (5%)
`["dot", "man"]`	2.256 μs (5%)
`["dot", "rf"]`	2.667 μs (5%)
`["dot", "xf"]`	2.689 μs (5%)
`["filter_map_map!", "man"]`	66.400 μs (5%)
`["filter_map_map!", "xf"]`	69.300 μs (5%)	144 bytes (1%)	8
`["filter_map_reduce", "man"]`	194.900 μs (5%)
`["filter_map_reduce", "xf"]`	194.900 μs (5%)
`["gemm", "fusedmul", "blas", "16"]`	3.394 ms (5%)
`["gemm", "fusedmul", "blas", "2"]`	2.514 ms (5%)
`["gemm", "fusedmul", "blas", "32"]`	4.976 ms (5%)
`["gemm", "fusedmul", "blas", "8"]`	3.039 ms (5%)
`["gemm", "fusedmul", "xf", "16"]`	5.107 ms (5%)	160 bytes (1%)	6
`["gemm", "fusedmul", "xf", "2"]`	597.302 μs (5%)	160 bytes (1%)	6
`["gemm", "fusedmul", "xf", "32"]`	10.506 ms (5%)	160 bytes (1%)	6
`["gemm", "fusedmul", "xf", "8"]`	2.545 ms (5%)	160 bytes (1%)	6
`["gemm", "mul", "linalg", "256"]`	657.502 μs (5%)
`["gemm", "mul", "linalg", "32"]`	3.800 μs (5%)
`["gemm", "mul", "linalg", "8"]`	300.000 ns (5%)
`["gemm", "mul", "man", "false", "256"]`	4.668 ms (5%)
`["gemm", "mul", "man", "false", "32"]`	7.000 μs (5%)
`["gemm", "mul", "man", "false", "8"]`	400.000 ns (5%)
`["gemm", "mul", "man", "ivdep", "256"]`	4.608 ms (5%)
`["gemm", "mul", "man", "ivdep", "32"]`	6.300 μs (5%)
`["gemm", "mul", "man", "ivdep", "8"]`	300.000 ns (5%)
`["gemm", "mul", "man", "true", "256"]`	4.621 ms (5%)
`["gemm", "mul", "man", "true", "32"]`	7.200 μs (5%)
`["gemm", "mul", "man", "true", "8"]`	400.000 ns (5%)
`["gemm", "mul", "xf", "false", "256"]`	4.550 ms (5%)	48 bytes (1%)	2
`["gemm", "mul", "xf", "false", "32"]`	6.900 μs (5%)	48 bytes (1%)	2
`["gemm", "mul", "xf", "false", "8"]`	400.000 ns (5%)	48 bytes (1%)	2
`["gemm", "mul", "xf", "ivdep", "256"]`	4.481 ms (5%)	48 bytes (1%)	2
`["gemm", "mul", "xf", "ivdep", "32"]`	5.800 μs (5%)	48 bytes (1%)	2
`["gemm", "mul", "xf", "ivdep", "8"]`	300.000 ns (5%)	48 bytes (1%)	2
`["gemm", "mul", "xf", "true", "256"]`	4.703 ms (5%)	48 bytes (1%)	2
`["gemm", "mul", "xf", "true", "32"]`	6.700 μs (5%)	48 bytes (1%)	2
`["gemm", "mul", "xf", "true", "8"]`	400.000 ns (5%)	48 bytes (1%)	2
`["missing_argmax", "man"]`	908.108 ns (5%)	32 bytes (1%)	1
`["missing_argmax", "rf"]`	2.167 μs (5%)	32 bytes (1%)	1
`["missing_argmax", "xf"]`	2.178 μs (5%)	32 bytes (1%)	1
`["missing_dot", "equiv"]`	1.350 μs (5%)	16 bytes (1%)	1
`["missing_dot", "man"]`	956.522 ns (5%)	16 bytes (1%)	1
`["missing_dot", "naive"]`	4.057 μs (5%)	16 bytes (1%)	1
`["missing_dot", "rf"]`	880.519 ns (5%)	16 bytes (1%)	1
`["missing_dot", "rf_nota"]`	1.440 μs (5%)	16 bytes (1%)	1
`["missing_dot", "xf"]`	183.801 μs (5%)	74.02 KiB (1%)	3865
`["missing_dot", "xf_nota"]`	187.601 μs (5%)	74.11 KiB (1%)	3866
`["partition_by", "man"]`	1.687 ms (5%)	352 bytes (1%)	4
`["partition_by", "xf"]`	1.624 ms (5%)	576 bytes (1%)	7

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["cat"]
["collect"]
["dot"]
["filter_map_map!"]
["filter_map_reduce"]
["gemm", "fusedmul", "blas"]
["gemm", "fusedmul", "xf"]
["gemm", "mul", "linalg"]
["gemm", "mul", "man", "false"]
["gemm", "mul", "man", "ivdep"]
["gemm", "mul", "man", "true"]
["gemm", "mul", "xf", "false"]
["gemm", "mul", "xf", "ivdep"]
["gemm", "mul", "xf", "true"]
["missing_argmax"]
["missing_dot"]
["partition_by"]

Julia versioninfo

Julia Version 1.3.1
Commit 2d5741174c (2019-12-30 21:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.3 LTS
  uname: Linux 5.0.0-1027-azure #29~18.04.1-Ubuntu SMP Mon Nov 25 21:18:57 UTC 2019 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      32389 s          0 s       2258 s      43194 s          0 s
       #2  2294 MHz      43642 s          0 s       2027 s      32392 s          0 s
       
  Memory: 6.782737731933594 GB (3516.4140625 MB free)
  Uptime: 795.0 sec
  Load Avg:  1.14892578125  1.07470703125  0.67724609375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, broadwell)

See also: JuliaFolds/Transducers.jl#167 This reverts commit 1f2c90b.

tkf added a commit to JuliaFolds/BangBang.jl that referenced this pull request Jan 18, 2020

Revert "Use create-pull-request v2 (#104)"

fb7397c

See also: JuliaFolds/Transducers.jl#167 This reverts commit 1f2c90b.

tkf mentioned this pull request Jan 18, 2020

Revert "Use create-pull-request v2 (#104)" JuliaFolds/BangBang.jl#105

Merged

tkf added the no changelog label Jan 18, 2020

mergify bot pushed a commit to JuliaFolds/BangBang.jl that referenced this pull request Jan 18, 2020

Revert "Use create-pull-request v2 (#104)" (#105)

7cd3934

See also: JuliaFolds/Transducers.jl#167 This reverts commit 1f2c90b.

tkf added the ready-to-merge:squash label Jan 18, 2020

mergify bot approved these changes Jan 18, 2020

View reviewed changes

mergify bot merged commit 4eb5d8d into master Jan 18, 2020

delete-merged-branch bot deleted the actions/trigger/pkg-update branch January 18, 2020 07:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Use create-pull-request v2 (#164)" #167

Revert "Use create-pull-request v2 (#164)" #167

tkf commented Jan 18, 2020

codecov-io commented Jan 18, 2020 •

edited

Loading

github-actions bot commented Jan 18, 2020

Judge result

Benchmark Report for /home/runner/work/Transducers.jl/Transducers.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Target

Baseline

Target result

Benchmark Report for /home/runner/work/Transducers.jl/Transducers.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Baseline result

Benchmark Report for /home/runner/work/Transducers.jl/Transducers.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Revert "Use create-pull-request v2 (#164)" #167

Revert "Use create-pull-request v2 (#164)" #167

Conversation

tkf commented Jan 18, 2020

codecov-io commented Jan 18, 2020 • edited Loading

Codecov Report

github-actions bot commented Jan 18, 2020

Judge result

Benchmark Report for /home/runner/work/Transducers.jl/Transducers.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Target

Baseline

Target result

Benchmark Report for /home/runner/work/Transducers.jl/Transducers.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Baseline result

Benchmark Report for /home/runner/work/Transducers.jl/Transducers.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

codecov-io commented Jan 18, 2020 •

edited

Loading