Skip to content

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Sep 17, 2025

#525

@michel2323
I didn't updated oneAPI.versioninfo(), can you do it after the PR?

Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/lib/support/liboneapi_support.jl b/lib/support/liboneapi_support.jl
index 5daba24..6db5fc8 100644
--- a/lib/support/liboneapi_support.jl
+++ b/lib/support/liboneapi_support.jl
@@ -205,8 +205,10 @@ mutable struct omatadd_descr end
 const omatadd_descr_t = Ptr{omatadd_descr}
 
 function onemkl_version(major, minor, patch)
-    @ccall liboneapi_support.onemkl_version(major::Ptr{Int64}, minor::Ptr{Int64},
-                                            patch::Ptr{Int64})::Cvoid
+    return @ccall liboneapi_support.onemkl_version(
+        major::Ptr{Int64}, minor::Ptr{Int64},
+        patch::Ptr{Int64}
+    )::Cvoid
 end
 
 function onemklHgemm_batch(device_queue, transa, transb, m, n, k, alpha, a, lda, b, ldb,
diff --git a/test/onemkl.jl b/test/onemkl.jl
index b75894c..7d88bf9 100644
--- a/test/onemkl.jl
+++ b/test/onemkl.jl
@@ -12,10 +12,10 @@ m = 20
 n = 35
 k = 13
 
-@testset "Version" begin
-    version_onemkl = oneMKL.version()
-    @test version_onemkl ≥ v"2025.2.0"
-end
+    @testset "Version" begin
+        version_onemkl = oneMKL.version()
+        @test version_onemkl ≥ v"2025.2.0"
+    end
 
 ############################################################################################
 @testset "level 1" begin

Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.74%. Comparing base (3d3278d) to head (3ca6c38).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
+ Coverage   79.70%   79.74%   +0.04%     
==========================================
  Files          45       45              
  Lines        2818     2824       +6     
==========================================
+ Hits         2246     2252       +6     
  Misses        572      572              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michel2323
Copy link
Member

@michel2323
I didn't updated oneAPI.versioninfo(), can you do it after the PR?

No problem.

@amontoison amontoison merged commit 719d893 into master Sep 17, 2025
2 checks passed
@amontoison amontoison deleted the oneapi_version branch September 17, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants