Skip to content

Conversation

splendidbug
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 3.88350% with 99 lines in your changes missing coverage. Please review.

Project coverage is 43.09%. Comparing base (04977ec) to head (3cda794).
Report is 3 commits behind head on main.

Files Patch % Lines
src/make_knowledge_packs.jl 0.00% 86 Missing ⚠️
src/utils.jl 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   43.93%   43.09%   -0.84%     
==========================================
  Files           8        8              
  Lines         585      601      +16     
==========================================
+ Hits          257      259       +2     
- Misses        328      342      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@svilupp svilupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have accidentally synced some actual data in examples/ folder.

When I asked for "examples", I meant a script (code) to run the knowledge pack generation process, but not the actual outputs that we create. Sorry if that wasn't clear

@splendidbug splendidbug merged commit 945a93a into main Aug 23, 2024
2 of 4 checks passed
@splendidbug splendidbug deleted the code_updates2 branch August 23, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants