Makie error when plotting meshes

[Tokazama]

I apologize if this is the wrong place for this issue. I pulled this MWE from the tests so that runs on Meshing#master but doesn't plot.

julia> A = rand(20,20,20);

julia> m = GeometryBasics.mesh(A,MarchingTetrahedra(1.0),origin=Point(Float32(0),Float32(0),Float32(0)),widths=Point(
Float32(1),Float32(1),Float32(1)));

julia> Makie.mesh(m)
┌ Warning: No strict ticks found
└ @ PlotUtils ~/.julia/packages/PlotUtils/Zg3aP/src/ticks.jl:283
┌ Warning: No strict ticks found
└ @ PlotUtils ~/.julia/packages/PlotUtils/Zg3aP/src/ticks.jl:283
┌ Warning: No strict ticks found
└ @ PlotUtils ~/.julia/packages/PlotUtils/Zg3aP/src/ticks.jl:283
ArgumentError: At least one finite value must be provided to formatter.with ticks: [-Inf, Inf]
ArgumentError: At least one finite value must be provided to formatter.with ticks: [-Inf, Inf]
ArgumentError: At least one finite value must be provided to formatter.with ticks: [-Inf, Inf]
┌ Warning: No strict ticks found
└ @ PlotUtils ~/.julia/packages/PlotUtils/Zg3aP/src/ticks.jl:283
┌ Warning: No strict ticks found
└ @ PlotUtils ~/.julia/packages/PlotUtils/Zg3aP/src/ticks.jl:283
┌ Warning: No strict ticks found
└ @ PlotUtils ~/.julia/packages/PlotUtils/Zg3aP/src/ticks.jl:283
ArgumentError: At least one finite value must be provided to formatter.with ticks: [-Inf, Inf]
ArgumentError: At least one finite value must be provided to formatter.with ticks: [-Inf, Inf]
ArgumentError: At least one finite value must be provided to formatter.with ticks: [-Inf, Inf]
┌ Warning: limits of scene contain non finite values: Float32[Inf, Inf, Inf] .. Float32[NaN, NaN, NaN]
└ @ AbstractPlotting ~/.julia/packages/AbstractPlotting/jOgYQ/src/scenes.jl:586
┌ Warning: No strict ticks found
└ @ PlotUtils ~/.julia/packages/PlotUtils/Zg3aP/src/ticks.jl:283
┌ Warning: No strict ticks found
└ @ PlotUtils ~/.julia/packages/PlotUtils/Zg3aP/src/ticks.jl:283
┌ Warning: No strict ticks found
└ @ PlotUtils ~/.julia/packages/PlotUtils/Zg3aP/src/ticks.jl:283
ArgumentError: At least one finite value must be provided to formatter.with ticks: [-Inf, Inf]
ArgumentError: At least one finite value must be provided to formatter.with ticks: [-Inf, Inf]
ArgumentError: At least one finite value must be provided to formatter.with ticks: [-Inf, Inf]
1   : #version 410
2   :
3   :
4   : in dvec3 vertices;
5   : uniform vec4 vertex_color;
6   : uniform vec2 texturecoordinates;
7   : in vec3 normals;
8   :
9   : uniform vec3 lightposition;
10  : uniform mat4 projection, view, model;
11  : void render(vec4 vertices, vec3 normals, mat4 viewmodel, mat4 projection, vec3 lightposition);
12  :
13  : uniform uint objectid;
14  : flat out uvec2 o_id;
15  : out vec2 o_uv;
16  : out vec4 o_color;
17  :
18  : vec3 to_3d(vec2 v){return vec3(v, 0);}
19  : vec3 to_3d(vec3 v){return v;}
20  :
21  : vec2 to_2d(float v){return vec2(v, 0);}
22  : vec2 to_2d(vec2 v){return v;}
23  :
24  : vec4 to_color(vec3 c){return vec4(c, 1);}
25  : vec4 to_color(vec4 c){return c;}
26  :
27  : void main()
28  : {
29  :     o_id = uvec2(objectid, gl_VertexID+1);
30  :     vec2 tex_uv = to_2d(texturecoordinates);
31  :     o_uv = vec2(1.0 - tex_uv.y, tex_uv.x);
32  :     o_color = to_color(vertex_color);
33  :     vec3 v = to_3d(vertices);
34  :     render(model * vec4(v, 1), (model * vec4(normals, 0)).xyz, view, projection, lightposition);
35  : }
36  :
┌ Warning: shader /Users/zchristensen/.julia/packages/GLMakie/S9Zib/src/GLVisualize/assets/shader/standard.vert didn'
t compile.
│ ERROR: 0:33: No matching function for call to to_3d(dvec3)
│ ERROR: 0:34: Use of undeclared identifier 'v'
└ @ GLMakie.GLAbstraction ~/.julia/packages/GLMakie/S9Zib/src/GLAbstraction/GLShader.jl:139
1   : #version 410
2   :
3   :
4   : in dvec3 vertices;
5   : uniform vec4 vertex_color;
6   : uniform vec2 texturecoordinates;
7   : in vec3 normals;
8   :
9   : uniform vec3 lightposition;
10  : uniform mat4 projection, view, model;
11  : void render(vec4 vertices, vec3 normals, mat4 viewmodel, mat4 projection, vec3 lightposition);
12  :
13  : uniform uint objectid;
14  : flat out uvec2 o_id;
15  : out vec2 o_uv;
16  : out vec4 o_color;
17  :
18  : vec3 to_3d(vec2 v){return vec3(v, 0);}
19  : vec3 to_3d(vec3 v){return v;}
20  :
21  : vec2 to_2d(float v){return vec2(v, 0);}
22  : vec2 to_2d(vec2 v){return v;}
23  :
24  : vec4 to_color(vec3 c){return vec4(c, 1);}
25  : vec4 to_color(vec4 c){return c;}
26  :
27  : void main()
28  : {
29  :     o_id = uvec2(objectid, gl_VertexID+1);
30  :     vec2 tex_uv = to_2d(texturecoordinates);
31  :     o_uv = vec2(1.0 - tex_uv.y, tex_uv.x);
32  :     o_color = to_color(vertex_color);
33  :     vec3 v = to_3d(vertices);
34  :     render(model * vec4(v, 1), (model * vec4(normals, 0)).xyz, view, projection, lightposition);
35  : }
36  :
┌ Warning: shader /Users/zchristensen/.julia/packages/GLMakie/S9Zib/src/GLVisualize/assets/shader/standard.vert didn'
t compile.
│ ERROR: 0:33: No matching function for call to to_3d(dvec3)
│ ERROR: 0:34: Use of undeclared identifier 'v'
└ @ GLMakie.GLAbstraction ~/.julia/packages/GLMakie/S9Zib/src/GLAbstraction/GLShader.jl:139
Error showing value of type Scene:
ERROR: program 34 not linked. Error in:
/Users/zchristensen/.julia/packages/GLMakie/S9Zib/src/GLVisualize/assets/shader/fragment_output.frag or /Users/zchris
tensen/.julia/packages/GLMakie/S9Zib/src/GLVisualize/assets/shader/util.vert or /Users/zchristensen/.julia/packages/G
LMakie/S9Zib/src/GLVisualize/assets/shader/standard.vert or /Users/zchristensen/.julia/packages/GLMakie/S9Zib/src/GLV
isualize/assets/shader/standard.frag
ERROR: One or more attached shaders not successfully compiled

Stacktrace:
 [1] error(::String, ::String, ::String, ::String) at ./error.jl:42
 [2] compile_program(::Array{GLMakie.GLAbstraction.Shader,1}, ::Array{Tuple{Int64,String},1}) at /Users/zchristensen/
.julia/packages/GLMakie/S9Zib/src/GLAbstraction/GLShader.jl:197
 [3] (::GLMakie.GLAbstraction.var"#62#67"{Dict{Symbol,Any},NTuple{4,String},Dict{String,String},Array{Array{String,1}
,1},Array{Array{String,1},1}})() at /Users/zchristensen/.julia/packages/GLMakie/S9Zib/src/GLAbstraction/GLShader.jl:2
62
 [4] get!(::GLMakie.GLAbstraction.var"#62#67"{Dict{Symbol,Any},NTuple{4,String},Dict{String,String},Array{Array{Strin
g,1},1},Array{Array{String,1},1}}, ::Dict{Any,GLMakie.GLAbstraction.GLProgram}, ::Tuple{NTuple{4,String},Array{Array{
String,1},1}}) at ./dict.jl:452
 [5] gl_convert(::GLMakie.GLVisualize.GLVisualizeShader, ::Dict{Symbol,Any}) at /Users/zchristensen/.julia/packages/G
LMakie/S9Zib/src/GLAbstraction/GLShader.jl:254
 [6] GLMakie.GLAbstraction.RenderObject(::Dict{Symbol,Any}, ::GLMakie.GLVisualize.GLVisualizeShader, ::GLMakie.GLAbst
raction.StandardPrerender, ::Nothing, ::GeometryBasics.HyperRectangle{3,Float32}, ::Nothing) at /Users/zchristensen/.
julia/packages/GLMakie/S9Zib/src/GLAbstraction/GLTypes.jl:327
 [7] assemble_robj(::Dict{Symbol,Any}, ::GLMakie.GLVisualize.GLVisualizeShader, ::GeometryBasics.HyperRectangle{3,Flo
at32}, ::UInt32, ::Nothing, ::Nothing) at /Users/zchristensen/.julia/packages/GLMakie/S9Zib/src/GLVisualize/visualize
_interface.jl:96
 [8] assemble_shader(::Dict{Symbol,Any}) at /Users/zchristensen/.julia/packages/GLMakie/S9Zib/src/GLVisualize/visuali
ze_interface.jl:117
 [9] visualize(::Any, ::Any, ::Any) at /Users/zchristensen/.julia/packages/GLMakie/S9Zib/src/GLVisualize/visualize_in
terface.jl:166
 [10] (::GLMakie.var"#108#112"{Mesh{...}})(::Dict{Symbol,Any}) at /Users/zchristensen/.julia/packages/GLMakie/S9Zib/s
rc/drawing_primitives.jl:384
 [11] (::GLMakie.var"#56#63"{GLMakie.var"#108#112"{Mesh{...}},GLMakie.Screen,Scene,Mesh{...}})() at /Users/zchristens
en/.julia/packages/GLMakie/S9Zib/src/drawing_primitives.jl:68
 [12] get!(::GLMakie.var"#56#63"{GLMakie.var"#108#112"{Mesh{...}},GLMakie.Screen,Scene,Mesh{...}}, ::Dict{UInt64,GLMa
kie.GLAbstraction.RenderObject}, ::UInt64) at ./dict.jl:452
 [13] cached_robj!(::GLMakie.var"#108#112"{Mesh{...}}, ::GLMakie.Screen, ::Scene, ::Mesh{...}) at /Users/zchristensen
/.julia/packages/GLMakie/S9Zib/src/drawing_primitives.jl:41
 [14] draw_atomic at /Users/zchristensen/.julia/packages/GLMakie/S9Zib/src/drawing_primitives.jl:349 [inlined]
 [15] insert!(::GLMakie.Screen, ::Scene, ::Mesh{...}) at /Users/zchristensen/.julia/packages/GLMakie/S9Zib/src/drawin
g_primitives.jl:158
 [16] insertplots!(::GLMakie.Screen, ::Scene) at /Users/zchristensen/.julia/packages/GLMakie/S9Zib/src/screen.jl:53
 [17] backend_display(::GLMakie.Screen, ::Scene) at /Users/zchristensen/.julia/packages/GLMakie/S9Zib/src/screen.jl:1
23
 [18] backend_display at /Users/zchristensen/.julia/packages/GLMakie/S9Zib/src/gl_backend.jl:59 [inlined]
 [19] display(::AbstractPlotting.PlotDisplay, ::Scene) at /Users/zchristensen/.julia/packages/AbstractPlotting/jOgYQ/
src/display.jl:45
 [20] display(::Any) at ./multimedia.jl:323
 [21] #invokelatest#1 at ./essentials.jl:712 [inlined]
 [22] invokelatest at ./essentials.jl:711 [inlined]
 [23] print_response(::IO, ::Any, ::Bool, ::Bool, ::Any) at /Users/julia/buildbot/worker/package_macos64/build/usr/sh
are/julia/stdlib/v1.4/REPL/src/REPL.jl:161
 [24] print_response(::REPL.AbstractREPL, ::Any, ::Bool, ::Bool) at /Users/julia/buildbot/worker/package_macos64/buil
d/usr/share/julia/stdlib/v1.4/REPL/src/REPL.jl:146
 [25] (::REPL.var"#do_respond#38"{Bool,REPL.var"#48#57"{REPL.LineEditREPL,REPL.REPLHistoryProvider},REPL.LineEditREPL
,REPL.LineEdit.Prompt})(::Any, ::Any, ::Any) at /Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/st
dlib/v1.4/REPL/src/REPL.jl:729
 [26] #invokelatest#1 at ./essentials.jl:712 [inlined]
 [27] invokelatest at ./essentials.jl:711 [inlined]
 [28] run_interface(::REPL.Terminals.TextTerminal, ::REPL.LineEdit.ModalInterface, ::REPL.LineEdit.MIState) at /Users
/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdlib/v1.4/REPL/src/LineEdit.jl:2354
 [29] run_frontend(::REPL.LineEditREPL, ::REPL.REPLBackendRef) at /Users/julia/buildbot/worker/package_macos64/build/
usr/share/julia/stdlib/v1.4/REPL/src/REPL.jl:1055
 [30] run_repl(::REPL.AbstractREPL, ::Any) at /Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdl
ib/v1.4/REPL/src/REPL.jl:206
 [31] (::Base.var"#764#766"{Bool,Bool,Bool,Bool})(::Module) at ./client.jl:383
 [32] #invokelatest#1 at ./essentials.jl:712 [inlined]
 [33] invokelatest at ./essentials.jl:711 [inlined]
 [34] run_main_repl(::Bool, ::Bool, ::Bool, ::Bool, ::Bool) at ./client.jl:367
 [35] exec_options(::Base.JLOptions) at ./client.jl:305
 [36] _start() at ./client.jl:484

[SimonDanisch]

Hm, seems like I'm missing some conversions for Float64 + Triangle{Int} meshes.
Try:

m = GeometryBasics.mesh(A,MarchingTetrahedra(1f0),origin=Point3f0(0) ,widths=Point3f0(1), pointtype=Point3f0, facetype=GLTriangle)

But this still doesn't work since the boundingbox is not finite:

julia> FRect3D(m)
GeometryBasics.HyperRectangle{3,Float32}(Float32[Inf, Inf, Inf], Float32[-Inf, -Inf, -Inf])

This must be a problem with Meshing.jl! Not sure if it's a regression from the GeometryBasic switch...

[Tokazama]

I'll try to dig a little more but I'm not sure I'm familiar enough with these packages to figure it out in addition to the changing API.

[SimonDanisch]

You could just try to switch back to the latest tag without GeometryBasics and see if the bounding box is also Inf

[Tokazama]

This is what I get on the latest tagged release.

julia> A = rand(20,20,20);

julia> m = GLNormalMesh(A,MarchingTetrahedra(1.0),origin=Point(Float32(0),Float32(0),Float32(0)),widths=Point(Float32(1),Float32(1),Float32(1)))
HomogenousMesh(
)

julia> GeometryTypes.FRect3D(m)
HyperRectangle{3,Float32}(Float32[Inf, Inf, Inf], Float32[-Inf, -Inf, -Inf])

[SimonDanisch]

Ok, so at that points its a meshing problem ;) Maybe try not random data? :D

[Tokazama]

I get this on the latest tagged release with real data

julia> m = GLNormalMesh(A,MarchingTetrahedra(1.0),origin=Point(Float32(0),Float32(0),Float32(0)),widths=Point(Float32(1),Float32(1),Float32(1)))
HomogenousMesh(
    faces: 613576xFace{3,OffsetInteger{-1,UInt32}},     vertices: 306342xPoint{3,Float32},     normals: 306342xNormal{3,Float32}, )


julia> GeometryTypes.FRect3D(m)
HyperRectangle{3,Float32}(Float32[0.2266541, 0.23978494, 0.0888582], Float32[0.5302575, 0.5390215, 0.55203134])

I'll see what it does on master now...

[Tokazama]

Okay, it works on master but Makie.mesh(m) still throws that big error containing

┌ Warning: shader /Users/zchristensen/.julia/packages/GLMakie/S9Zib/src/GLVisualize/assets/shader/standard.vert didn'
t compile.
│ ERROR: 0:33: No matching function for call to to_3d(dvec3)
│ ERROR: 0:34: Use of undeclared identifier 'v'
└ @ GLMakie.GLAbstraction ~/.julia/packages/GLMakie/S9Zib/src/GLAbstraction/GLShader.jl:139
Error showing value of type Scene:
ERROR: program 34 not linked. Error in:
/Users/zchristensen/.julia/packages/GLMakie/S9Zib/src/GLVisualize/assets/shader/fragment_output.frag or /Users/zchris
tensen/.julia/packages/GLMakie/S9Zib/src/GLVisualize/assets/shader/util.vert or /Users/zchristensen/.julia/packages/G
LMakie/S9Zib/src/GLVisualize/assets/shader/standard.vert or /Users/zchristensen/.julia/packages/GLMakie/S9Zib/src/GLV
isualize/assets/shader/standard.frag
ERROR: One or more attached shaders not successfully compiled

I am able to run some examples from the Makie docs using meshes, so I don't think it's an installation problem.

[SimonDanisch]

That's still including Float64! You need to make sure that the mesh is using Point3f0 + GLTriangleFace

[sjkelly]

Thanks for the report. I am actually seeing the same error, and got some fixes last night. The error I see is slightly different and my shaders are version 330. I believe shader version 410 should handle Float64, so I am not sure why you are seeing the problem.

Regardless, the conversion machinery needs to be here in a lot of cases. Caution that the API on master might change in order to fix.

[SimonDanisch]

I believe shader version 410 should handle Float64, so I am not sure why you are seeing the problem.

Yeah but my shader don't support them ^^

[Tokazama]

Adding GLTriangleFace worked for this. I foolishly assumed that if I specified Float32 on all the other arguments it would be sufficient.

I'm one step closer to beautiful brain parcellations!!!