First Pass of performance improvements to Marching Tetrahedra #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting my commits from my other branch to make merging and rebase easier.
before:
"MarchingTetrahedra{Float64}" => BenchmarkTools.Trial:
memory estimate: 17.53 MiB
allocs estimate: 445006
--------------
minimum time: 45.394 ms (0.00% GC)
median time: 47.722 ms (2.93% GC)
mean time: 58.909 ms (3.89% GC)
maximum time: 981.840 ms (9.03% GC)
--------------
samples: 85
evals/sample: 1
after:
"MarchingTetrahedra{Float64}" => BenchmarkTools.Trial:
memory estimate: 10.27 MiB
allocs estimate: 120396
--------------
minimum time: 11.393 ms (0.00% GC)
median time: 12.211 ms (0.00% GC)
mean time: 13.944 ms (3.29% GC)
maximum time: 531.305 ms (11.73% GC)
--------------
samples: 359
evals/sample: 1
I have identified other performance hotspots here that bring this under the 10ms mark: https://github.com/JuliaGeometry/Meshing.jl/tree/sjk/mt-fst2
But for the test cases to pass I need parts of the workingprecision branch.