Add RotMatrix2, RotMatrix3 type aliases. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unrelated failure on OSX nightly, I believe. |
c42f
approved these changes
Jun 29, 2017
test/rotation_tests.jl
Outdated
|
|
||
| @testset "Testing type aliases" begin | ||
| @test typeof(eye(RotMatrix{2, Float64})) == RotMatrix2{Float64} | ||
| @test typeof(eye(RotMatrix{3, Float64})) == RotMatrix3{Float64} |
There was a problem hiding this comment.
This can be a nice place to use isa:
@test eye(RotMatrix{2, Float64}) isa RotMatrix2{Float64}
tkoolen
force-pushed
the
rotmatrix-type-aliases
branch
from
ada14a4
to
57b7bc2
Compare
|
The latest OSX failure is unrelated for sure. Restarted it for good measure, and now it seems to have gone through. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found these come in handy.